Axes for all #331
Merged
Axes for all #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
commented
Feb 14, 2018
| <ColorPicker label={_('Font Color')} attr="titlefont.color" /> | ||
| </AxesFold> | ||
| <AxisRequiredPanel | ||
| emptyPanelHeader={_('Your plot does not have any axes to style.')} |
Contributor
Author
There was a problem hiding this comment.
I just wrapped everything in AxisRequiredPanel here
VeraZab
commented
Feb 14, 2018
| this.axes = []; | ||
|
|
||
| // Plotly.js should really have a helper function for this, but until it does.. | ||
| Object.keys(fullContainer._subplots) |
Contributor
Author
There was a problem hiding this comment.
ok, so subplots will be step 2, after this pr, that is why I disabled a test somewhat related to them, above.
Need to think about this a little more when I'm writing this function here.
Contributor
Author
|
@nicolaskruchten this is a first pass that takes care of axes for all plot types, and does not use the plotly.Axes.list() function that doesn't work on plots other than cartesian. I'm taking care of subplots next.. Would you give this a look? |
VeraZab
force-pushed
the
axes-for-all
branch
from
546fffd to
36dae8f
Compare
Contributor
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.