Shape and Image panels #332
Conversation
| break; | ||
|
|
||
| case EDITOR_ACTIONS.DELETE_IMAGE: | ||
| if (isNumeric(payload.imageIndex)) { |
There was a problem hiding this comment.
I guess on a later pass we could combine these delete 'annotations' 'shapes' 'images' actions into one
There was a problem hiding this comment.
yeah, this was a dirty copy-paste job... We'll see if it turns out that these evolve in different directions and if not, we can DRY them up.
| const key = `annotations[${annotationIndex}]`; | ||
| const value = {text: 'new text'}; | ||
| const value = {text: _('new text')}; | ||
|
|
| connectImageToLayout, | ||
| connectAxesToLayout, | ||
| connectLayoutToPlot, | ||
| connectToContainer, |
There was a problem hiding this comment.
can we add these to the README
| StyleShapesPanel, | ||
| StyleImagesPanel, | ||
| StyleTracesPanel, | ||
| } from './default_panels'; |
There was a problem hiding this comment.
same, can we add these to the README
There was a problem hiding this comment.
Hmmm well none of the other default panels are in the readme, so I would vote no...
There was a problem hiding this comment.
I mean the positionningRef, the Accordions, the connect functions : )
| {label: _('Hide'), value: false}, | ||
| ]} | ||
| /> | ||
| <TextEditor attr="source" label={_('Source')} show /> |
There was a problem hiding this comment.
yeah, we need the component hein..
would you mind creating the issue so we don't forget..
There was a problem hiding this comment.
yep. we can use react-dropzone I think, I used it for https://react-pivottable.js.org/ and it works great.
|
PR feedback addressed! |
|
💃 |
Roughed in, lots of fit'n'finish needed :(