🔪 supplyPlotProps #438
🔪 supplyPlotProps #438
Conversation
| <NumericFractionInverse label={_('Box Width')} attr="boxgap" /> | ||
| <NumericFraction label={_('Bar Padding')} attr="bargroupgap" /> | ||
| <NumericFraction label={_('Box Padding')} attr="boxgroupgap" /> | ||
| </LayoutSection> |
There was a problem hiding this comment.
This abstraction / API is waaaay better. It looks so freaking obvious now. All the good fixes do. Made my day!
|
@VeraZab this is now waiting on your renaming/visibility stuff and then I can 🔪 the rest of the |
| } | ||
| }; | ||
|
|
||
| export const shamefullyAdjustGeo = ({layout: {geo = {}}}, {update}) => { |
There was a problem hiding this comment.
@VeraZab this is finally how I got the geo stuff sorted. I also had to deal with the projection centers etc. Note that setting the value to {} essentially clears it, so this restores the defaults instead of hardcoding mappings, which is nice :)
|
Hmmm now that I look at it, it may be easier to merge my change in first... I could help you rebase :) |
|
yeah, looks like it'd be easy to rebase this one.. |
|
💃 |
Fixes #436