Add table columns if none specified #501
Conversation
| graphDiv.data[traceIndexes[0]].cells.valuessrc || null; | ||
| } else if ( | ||
| update['cells.values'] === null && | ||
| !graphDiv.data[traceIndexes[0]].header.valuessrc |
There was a problem hiding this comment.
@VeraZab do we need to use your special from/to functions here to extract an array of data source names?
There was a problem hiding this comment.
I think it should be ok without any adjustments, as its the data selector itself that handles the from and to src conversions, everywhere else, the editor just uses its own format, its just in that component that we care about it, because that's where the fullValue is matched up to the dataSourceOptions
There was a problem hiding this comment.
ok, great, thanks!
There was a problem hiding this comment.
it's actually going to show very weird names in strembed, like ~:100:1000, this does nothing to prettify names, its just 2 functions that allow for custom src formatting between the editor and another app.
And those 2 functions are only used in the DataSelector, because that's the only component that has to interface between dataSourceOptions, which can be in a very custom format, and the react-chart-editor's way of handling srcs: array based for multi columns, and string based otherwise.
But these functions won't make the names of srcs prettier..
|
💃 |
1 similar comment
|
💃 |
Closes #499