default trace fix #539
Merged
default trace fix #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/EditorControls.js
Outdated
| // can't use default prop because plotly.js mutates it: | ||
| // https://github.com/plotly/react-chart-editor/issues/509 | ||
| graphDiv.data.push( | ||
| this.props.useAsDefaultTrace |
Contributor
There was a problem hiding this comment.
I think this is still vulnerable to this problem... I would go with a generator just to be sure.
VeraZab
force-pushed
the
default-trace-fix
branch
2 times, most recently
from
e3c12f0 to
dcd13b5
Compare
VeraZab
force-pushed
the
default-trace-fix
branch
from
dcd13b5 to
9683a80
Compare
Contributor
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #509
cc @nicolaskruchten