fix for DataSelector switching from 2d sources #598
Conversation
dmt0
force-pushed
the
dataselector-2d-fix
branch
from
3312e6b to
4c001c5
Compare
|
I'll let @VeraZab review this guy |
| ].includes(props.container.type)) || | ||
| (props.container.type === 'table' && props.attr !== 'columnorder'); | ||
| (props.container.type === 'table' && props.attr !== 'columnorder') || | ||
| Array.isArray(this.fullValue); |
There was a problem hiding this comment.
well, I don't think all this.fullValues that are arrays are 2d..
2d means an array of arrays,
so, I would check that if fullValue is an array, that all the elements in it are arrays too..
There was a problem hiding this comment.
No, this.fullValue is made of datasources, not data.
So for tables, contour Z, etc. it looks like ['ints', 'big ints'...]
Would it be different in cloud?
There was a problem hiding this comment.
oh ok, so you're saying that when only one column can be selected, this.fullValue will not be an array? it will just be a string?
if that's the case, then ok, yes, I approuve of this logic change
There was a problem hiding this comment.
yep, it's a string like "ints"
closes #490