include all trace types in constants #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
reviewed
Dec 17, 2018
| }, | ||
| HIDDEN: { | ||
| value: 'HIDDEN', | ||
| label: '', |
Contributor
There was a problem hiding this comment.
so because it does not have a label its going to be hidden?
Contributor
Author
There was a problem hiding this comment.
no, it's hidden because it's not included in the next array
VeraZab
reviewed
Dec 17, 2018
| 'histogram2dcontour', | ||
| 'carpet', | ||
| 'scattercarpet', | ||
| 'contourcarpet', |
Contributor
There was a problem hiding this comment.
but so, should we also add parcoords and other unsupported types, just in case someone creates them from the API,
or I guess that just returning null in getAllAxes takes care of the panel not erroring out for those traces?
Contributor
Author
There was a problem hiding this comment.
returning null causes the Axes panel to be hidden :)
Contributor
|
seems good 💃 if that question above is how it does not error out for plots created through api but not in RCE yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses errors from #788 ... doesn't add subplots support though!