You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because these props would often be defined in an object literal, you don't need to specify the function keyword or =>. But you're right in those cases that you shouldn't use the const keyword.
Since I don't use JSX, I was thinking more in terms of using an object literal for props. However, most people probably use JSX, so your style would be more natural for code in JSX within something like toJson={ /*...*/ }.
The thing is, the expression const toJson(object) = object; is syntactically wrong. That was the main purpose of this PR.
The second goal was to add some clearance in cy => this.cy = cy - at first look it's hard to say if it is (cy => this.cy) = cy or cy => (this.cy = cy). Currly braces also give reader information that the cy prop function doesn't expect anything to return.
PS I've just noticed that my const diff = (objectA, objectB) => objectA !== objectB; could be more verbose if you wrap objectA !== objectB in parenthesis ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.