Skip to content

chore: Dependency management#131

Merged
toby-coleman merged 4 commits intomainfrom
chore/dependencies
Apr 16, 2025
Merged

chore: Dependency management#131
toby-coleman merged 4 commits intomainfrom
chore/dependencies

Conversation

@toby-coleman
Copy link
Contributor

Summary

Update dependency version specs so that breaking changes to dependencies do not break this package. Also closes #90.

Changes

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @toby-coleman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request focuses on dependency management by updating version specifiers in pyproject.toml to prevent breaking changes from dependency updates. It also enables Dependabot for automated dependency updates, and updates the uv.lock file to reflect the new dependency constraints. The changes in uv.lock also update the websockets package to version 14.2.

Highlights

  • Dependency Versioning: Updates version specifiers in pyproject.toml to use more restrictive ranges, ensuring that breaking changes in dependencies do not affect the project.
  • Dependabot Configuration: Enables Dependabot with a configuration file (.github/dependabot.yml) to automate dependency updates, including a new entry for the uv package ecosystem.
  • Dependency Lockfile Update: Updates the uv.lock file to reflect the changes in pyproject.toml, ensuring consistent dependency versions across environments. Also downgrades the websockets package to version 14.2.

Changelog

  • .github/dependabot.yml
    • Added a new entry for the uv package ecosystem to the Dependabot configuration, scheduling monthly updates.
  • pyproject.toml
    • Updated version specifiers for dependencies like pydantic-settings, structlog, that-depends, llama-index-core, llama-index-llms-openai, ray, and websockets to include upper bounds, preventing unexpected breaking changes.
    • Changed websockets version specifier from >=14.2 to ~=14.2.
  • uv.lock
    • Updated dependency versions to match the new specifiers in pyproject.toml, including adding upper bounds to llama-index-core, llama-index-llms-openai, pydantic-settings, ray, structlog, and that-depends.
    • Downgraded websockets from version 15.0.1 to 14.2.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A lockfile's embrace,
Dependencies held in place,
No breaking change fear,
Updates crystal clear,
Stability we chase.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependency version specs to prevent breaking changes and enables Dependabot for dependency management. The changes look good overall, but I have a few suggestions to improve clarity and maintainability.

Summary of Findings

  • Dependency version specifiers: The pull request updates dependency version specifiers to prevent breaking changes. This is a good practice to ensure stability and avoid unexpected issues due to dependency updates.
  • Dependabot configuration: The pull request enables Dependabot for automated dependency updates. This is a great way to keep dependencies up-to-date and address security vulnerabilities.

Merge Readiness

The changes in this pull request are beneficial for dependency management and overall project stability. However, I recommend addressing the identified issues before merging to ensure code quality and maintainability. I am unable to approve this pull request, and suggest that others review and approve this code before merging.

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@chrisk314 chrisk314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In was thinking we should change these version constraints the other day actually...

Let's be consistent and use the more verbose format for the version constraints.

@toby-coleman toby-coleman dismissed chrisk314’s stale review April 16, 2025 12:27

Resolved in latest commits

@toby-coleman toby-coleman merged commit e1911ce into main Apr 16, 2025
8 checks passed
@toby-coleman toby-coleman deleted the chore/dependencies branch April 16, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable dependabot/uv integration

2 participants