Skip to content

fix: Optuna storage configuration issue in Tuner#163

Merged
toby-coleman merged 8 commits intomainfrom
copilot/fix-162
Sep 3, 2025
Merged

fix: Optuna storage configuration issue in Tuner#163
toby-coleman merged 8 commits intomainfrom
copilot/fix-162

Conversation

Copy link
Contributor

Copilot AI commented Aug 24, 2025 •
edited by toby-coleman
Loading

Summary

Closes #162.

Changes

  • Convert storage URIs to Optuna RDBStorage objects.

Copilot AI and others added 2 commits August 24, 2025 18:24
@toby-coleman
Initial commit - Plan for fixing Optuna storage issue
b4400cf 
Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>
@toby-coleman
Fix Optuna storage issue by converting URI strings to storage objects
4b15f1c 
Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>
Copilot AI changed the title [WIP] bug: Tune does not work when configured with storage Fix Optuna storage configuration issue in Tuner Aug 24, 2025
Copilot AI requested a review from toby-coleman August 24, 2025 18:31
@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@toby-coleman toby-coleman changed the title Fix Optuna storage configuration issue in Tuner fix: Optuna storage configuration issue in Tuner Aug 24, 2025
toby-coleman
toby-coleman reviewed Aug 25, 2025
View reviewed changes
Copy link
Contributor

@toby-coleman toby-coleman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is failing the lint checks: run ruff format . and ruff check --fix . to resolve. @copilot

@toby-coleman toby-coleman marked this pull request as ready for review August 25, 2025 13:03
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Benchmark comparison for bbfd6d1f (base) vs 34e55948 (PR)


------------------------------------------------------------------------------------------------------------------- benchmark: 2 tests ------------------------------------------------------------------------------------------------------------------
Name (time in ms)                                                                         Min                 Max                Mean             StdDev              Median                IQR            Outliers     OPS            Rounds  Iterations
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_benchmark_process_run (main/.benchmarks/Linux-CPython-3.12-64bit/0001_base)     876.8803 (1.0)      884.1656 (1.0)      880.0942 (1.0)       2.8851 (1.0)      880.1696 (1.0)       4.4083 (1.0)           2;0  1.1362 (1.0)           5           1
test_benchmark_process_run (pr/.benchmarks/Linux-CPython-3.12-64bit/0001_pr)         877.4423 (1.00)     920.4996 (1.04)     892.2345 (1.01)     18.0490 (6.26)     882.3180 (1.00)     25.0215 (5.68)          1;0  1.1208 (0.99)          5           1
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Benchmark comparison for bbfd6d1f (base) vs a1828acc (PR)


------------------------------------------------------------------------------------------------------------------- benchmark: 2 tests ------------------------------------------------------------------------------------------------------------------
Name (time in ms)                                                                         Min                 Max                Mean             StdDev              Median                IQR            Outliers     OPS            Rounds  Iterations
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_benchmark_process_run (main/.benchmarks/Linux-CPython-3.12-64bit/0001_base)     870.5807 (1.0)      879.0949 (1.0)      874.9459 (1.0)       3.4159 (1.0)      875.2538 (1.0)       5.5336 (1.0)           2;0  1.1429 (1.0)           5           1
test_benchmark_process_run (pr/.benchmarks/Linux-CPython-3.12-64bit/0001_pr)         874.6846 (1.00)     930.8320 (1.06)     890.8397 (1.02)     22.8947 (6.70)     882.1692 (1.01)     21.2386 (3.84)          1;1  1.1225 (0.98)          5           1
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@toby-coleman toby-coleman merged commit 1d06a85 into main Sep 3, 2025
28 of 31 checks passed
@toby-coleman toby-coleman deleted the copilot/fix-162 branch September 3, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toby-coleman toby-coleman toby-coleman left review comments

Assignees

@toby-coleman toby-coleman

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Tune does not work when configured with storage

2 participants

@toby-coleman