Skip to content

chore: Use uvloop as the async event loop#166

Merged
chrisk314 merged 8 commits intomainfrom
chore/uvloop
Sep 4, 2025
Merged

chore: Use uvloop as the async event loop#166
chrisk314 merged 8 commits intomainfrom
chore/uvloop

Conversation

@toby-coleman
Copy link
Contributor

@toby-coleman toby-coleman commented Sep 3, 2025

Summary

Closes #164 by changing to uvloop.

Changes

  • Update calls to asyncio.run.
  • Update tests as per pytest-asyncio docs.
  • Tests use uvloop (Linux/MacOS only), but the package code can fallback to the default event loop on Windows.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @toby-coleman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request transitions the project's asynchronous operations to use uvloop, a fast drop-in replacement for asyncio's event loop. This change aims to enhance the performance and efficiency of concurrent tasks by leveraging uvloop's C-based implementation. It involves updating direct event loop calls and configuring the test environment to utilize the new loop.

Highlights

  • Core Async Event Loop Change: The primary asynchronous event loop has been switched from the default asyncio loop to uvloop for improved performance.
  • asyncio.run Replacements: All direct calls to asyncio.run across the codebase have been updated to use uvloop.run to leverage the new event loop.
  • Dependency Management: uvloop has been added as a new dependency in pyproject.toml and uv.lock to ensure its availability.
  • Test Suite Configuration: The test suite has been updated to configure uvloop as the default event loop policy for tests, aligning with the pytest-asyncio documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Benchmark comparison for c32f38b7 (base) vs 6fa86aaf (PR)


------------------------------------------------------------------------------------------------------------------ benchmark: 2 tests -----------------------------------------------------------------------------------------------------------------
Name (time in ms)                                                                         Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_benchmark_process_run (pr/.benchmarks/Linux-CPython-3.12-64bit/0001_pr)         799.3452 (1.0)      811.6953 (1.0)      807.7121 (1.0)      4.8846 (1.39)     808.5215 (1.0)      4.7732 (1.35)          1;0  1.2381 (1.0)           5           1
test_benchmark_process_run (main/.benchmarks/Linux-CPython-3.12-64bit/0001_base)     866.8073 (1.08)     875.5793 (1.08)     872.8233 (1.08)     3.5126 (1.0)      874.4522 (1.08)     3.5275 (1.0)           1;0  1.1457 (0.93)          5           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully switches the asyncio event loop to uvloop to improve performance. The changes are consistent across the codebase, including updating runtime calls and test configurations.

However, there is a critical issue regarding cross-platform compatibility. uvloop is not supported on Windows, and the current implementation makes it a hard dependency. This will cause installation and runtime failures on Windows systems.

My review comments provide specific suggestions to make uvloop an optional dependency for non-Windows platforms and to ensure the code falls back gracefully to the standard asyncio event loop when uvloop is not available. This pattern needs to be applied consistently across all files that now use uvloop.

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Benchmark comparison for c32f38b7 (base) vs 901d1121 (PR)


------------------------------------------------------------------------------------------------------------------ benchmark: 2 tests ------------------------------------------------------------------------------------------------------------------
Name (time in ms)                                                                         Min                 Max                Mean            StdDev              Median                IQR            Outliers     OPS            Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_benchmark_process_run (pr/.benchmarks/Linux-CPython-3.12-64bit/0001_pr)         801.1078 (1.0)      817.8298 (1.0)      808.8088 (1.0)      7.3921 (1.0)      806.1846 (1.0)      13.0643 (1.47)          2;0  1.2364 (1.0)           5           1
test_benchmark_process_run (main/.benchmarks/Linux-CPython-3.12-64bit/0001_base)     876.3899 (1.09)     897.5204 (1.10)     883.2647 (1.09)     8.3710 (1.13)     880.4705 (1.09)      8.8765 (1.0)           1;0  1.1322 (0.92)          5           1
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

Copy link
Contributor

@chrisk314 chrisk314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrisk314 chrisk314 merged commit e597f92 into main Sep 4, 2025
19 checks passed
@chrisk314 chrisk314 deleted the chore/uvloop branch September 4, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace stdlib asyncio event loop with uvloop

2 participants