feat: LLMImageProcessor and model routing example#179
Conversation
Summary of ChangesHello @toby-coleman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Benchmark comparison for |
There was a problem hiding this comment.
Code Review
This pull request introduces a new LLMImageProcessor component for handling multimodal LLM interactions and a comprehensive example notebook demonstrating its use in an event-driven routing pipeline. The code is well-structured, notably with the introduction of a _LLMBase class to abstract common LLM logic, which improves maintainability. The new functionality is also accompanied by good unit tests.
My review focuses on the new example notebook, where I've identified a few areas for improvement regarding comment accuracy, code efficiency, and readability. These are minor changes to enhance the quality of the example for users.
examples/demos/llm/004_image_processing/local-and-remote-image-processing.ipynb
Outdated
Show resolved
Hide resolved
examples/demos/llm/004_image_processing/local-and-remote-image-processing.ipynb
Outdated
Show resolved
Hide resolved
examples/demos/llm/004_image_processing/local-and-remote-image-processing.ipynb
Show resolved
Hide resolved
examples/demos/llm/004_image_processing/local-and-remote-image-processing.ipynb
Show resolved
Hide resolved
examples/demos/llm/004_image_processing/local-and-remote-image-processing.ipynb
Show resolved
Hide resolved
examples/demos/llm/004_image_processing/local-and-remote-image-processing.ipynb
Show resolved
Hide resolved
examples/demos/llm/004_image_processing/local-and-remote-image-processing.ipynb
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Benchmark comparison for |
chrisk314
left a comment
There was a problem hiding this comment.
Looks good! Nice example of event driven models. Just a couple of small questions/comments.
examples/demos/llm/004_image_processing/local-and-remote-image-processing.ipynb
Show resolved
Hide resolved
examples/demos/llm/004_image_processing/local-and-remote-image-processing.ipynb
Show resolved
Hide resolved
|
Benchmark comparison for |
|
Benchmark comparison for |
Summary
Adds a new component for image processing using multimodal LLMs.
Changes
LLMImageProcessorlibrary component to allow images to be passed to multimodal LLMs.