Skip to content

directly clear search outliner when closing tab (don't stop timer, as… #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothyschoen merged 1 commit into from
Jan 17, 2024
Merged

directly clear search outliner when closing tab (don't stop timer, as… #1396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Source/PluginEditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,7 @@ void PluginEditor::closeTab(Canvas* cnv)
auto patch = cnv->refCountedPatch;

sidebar->hideParameters();
sidebar->clearSearchOutliner();

patch->setVisible(false);

Expand Down
9 changes: 5 additions & 4 deletions Source/Sidebar/SearchPanel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ class SearchPanel : public Component, public KeyListener, public Timer
{
return false;
}

void clear()
{
patchTree.clearValueTree();
}

void timerCallback() override
{
Expand All @@ -115,10 +120,6 @@ class SearchPanel : public Component, public KeyListener, public Timer
currentCanvas->needsSearchUpdate = false;
updateResults();
}
if (!cnv) {
patchTree.clearValueTree();
stopTimer();
}
}

void visibilityChanged() override
Expand Down
5 changes: 5 additions & 0 deletions Source/Sidebar/Sidebar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,3 +408,8 @@ void Sidebar::updateConsole(int numMessages, bool newWarning)

console->update();
}

void Sidebar::clearSearchOutliner()
{
searchPanel->clear();
}
2 changes: 2 additions & 0 deletions Source/Sidebar/Sidebar.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ class Sidebar : public Component
void clearConsole();
void updateConsole(int numMessages, bool newWarning);

void clearSearchOutliner();

void updateAutomationParameters();

static constexpr int dragbarWidth = 6;
Expand Down