Fixing default for excludedConfig (README.md)#86
Merged
boazpoolman merged 2 commits intopluginpal:masterfrom Feb 7, 2023
Merged
Fixing default for excludedConfig (README.md)#86boazpoolman merged 2 commits intopluginpal:masterfrom
boazpoolman merged 2 commits intopluginpal:masterfrom
Conversation
Hi, I noticed the default value for `excludedConfig` was updated in pluginpal@4d44e03 I also replaced double-quotes with single-quotes to match the lines above (e.g. line `413` is `excludedTypes: ['admin-role']`).
boazpoolman
requested changes
Feb 7, 2023
Member
boazpoolman
left a comment
boazpoolman
left a comment
There was a problem hiding this comment.
Could you also add the change on line 358? Then the readme is all good and up-to-date 🙂
Contributor
Author
Sure, I missed it, thank you! 😉 |
boazpoolman
approved these changes
Feb 7, 2023
Member
boazpoolman
left a comment
boazpoolman
left a comment
There was a problem hiding this comment.
Perfect! Thank you for this 🙃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I noticed the default value for
excludedConfigwas updated in 4d44e03I also replaced double-quotes with single-quotes to match the lines above (e.g. line
413isexcludedTypes: ['admin-role']).I hope this helps, thank you for your time and for maintaining this great tool.