Skip to content

Fix item match #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rom1-B merged 2 commits into from
Nov 27, 2025
Merged

Fix item match #70

Rom1-B merged 2 commits into from
Nov 27, 2025

Conversation

@stonebuzz
Copy link
Contributor

@stonebuzz stonebuzz commented Nov 26, 2025 •
edited by Rom1-B
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

Fix for the searchItemMatch Function

Currently, if no host returned by the Centreon API matches the GLPI host (Computer), the function incorrectly returns true. This behavior is misleading and does not reflect the actual result (should be false).

Screenshots (if appropriate):

@stonebuzz stonebuzz requested a review from Mary-Clb November 26, 2025 15:42
@stonebuzz stonebuzz self-assigned this Nov 26, 2025
@stonebuzz stonebuzz added the bug Something isn't working label Nov 26, 2025
@stonebuzz stonebuzz mentioned this pull request Nov 26, 2025
Closed
2 tasks
@stonebuzz stonebuzz requested a review from Rom1-B November 27, 2025 08:11
@Rom1-B Rom1-B merged commit 19ff2d6 into main Nov 27, 2025
3 checks passed
@Rom1-B Rom1-B deleted the fix_item_match branch November 27, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rom1-B Rom1-B Rom1-B approved these changes

@Mary-Clb Mary-Clb Mary-Clb approved these changes

Assignees

@stonebuzz stonebuzz

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Centreon 1.1.1 + GLPI 11.0.2 : Warning: Undefined array key "centreon_id

4 participants

@stonebuzz @Rom1-B @Mary-Clb