- 
                Notifications
    
You must be signed in to change notification settings  - Fork 73
 
Fix(Core): fix migration error when container are related to Generico… #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           waiting from community feedback  | 
    
| 
           I’ve added an additional check. Now, before verifying whether the GenericObject plugin is at the correct version (based on the presence of its table), I first check if any containers are actually linked to GenericObject. This change was motivated by a support case: the client had generic objects, and the Fields plugin was crashing because the GenericObject End of Life Updater plugin wasn’t enabled — even though no containers were associated with GenericObject.  | 
    
d99961c    to
    c666898      
    Compare
  
    …bject Model or Type
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
c666898    to
    2b8edfb      
    Compare
  
    
…bject Model or Type
Checklist before requesting a review
Please delete options that are not relevant.
Description
If a container field is attached to a model or type derived from a GenericObject,
the migration of the container to CustomAssets fails because it does not take the model or type into account.
In GLPI:
Glpi\CustomAsset\CarAssetGlpi\CustomAsset\CarAssetModelGlpi\CustomAsset\CarAssetTypeThe current migration method does not consider that the container may be attached to a model or type of a GenericObject.
Screenshots (if appropriate):