Fix breaking change introduced by #3449#3589
Merged
stonebuzz merged 1 commit intopluginsGLPI:support/2.13.0from May 12, 2025
Merged
Fix breaking change introduced by #3449#3589stonebuzz merged 1 commit intopluginsGLPI:support/2.13.0from
stonebuzz merged 1 commit intopluginsGLPI:support/2.13.0from
Conversation
stonebuzz
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes description
#3449 introduce a breaking change by adding a new
getTemplateItemtypeNameabstract method to a base class in a minor release.This breaks any code that extends this class.
Fixed by moving the
getTemplateByNamemethod toPluginFormcreatorAbstractItilTarget(which already has agetTemplateItemtypeNameabstract method) as it is only used by CommonITILObject anyway.References
Internal ref: 35312.