Skip to content

Bugfix: Hide client secret field using password input type#129

Merged
Rom1-B merged 2 commits intopluginsGLPI:mainfrom
dvbnl:main
Apr 2, 2026
Merged

Bugfix: Hide client secret field using password input type#129
Rom1-B merged 2 commits intopluginsGLPI:mainfrom
dvbnl:main

Conversation

@dvbnl
Copy link
Copy Markdown
Contributor

@dvbnl dvbnl commented Mar 31, 2026

Checklist before requesting a review

Please delete options that are not relevant.

  • [Done] I have performed a self-review of my code.
  • [Screenshot] I have added tests (when available) that prove my fix is effective or that my feature works.

Description

  • It fixes # (issue number, if applicable) - The Graph API secret was not masked and displayed as plain text
  • Here is a brief description of what this PR does - it adds the password type attribute so the field is masked

Screenshots (if appropriate):

image

@dvbnl
Copy link
Copy Markdown
Contributor Author

dvbnl commented Mar 31, 2026

Issue: #115

Copy link
Copy Markdown
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvbnl

can you adapt CHANGELOG.md too

@dvbnl
Copy link
Copy Markdown
Contributor Author

dvbnl commented Apr 1, 2026

@dvbnl

can you adapt CHANGELOG.md too

@stonebuzz i've just updated the changelog! (without versioning for now)

@stonebuzz stonebuzz requested a review from Rom1-B April 2, 2026 05:48
@Rom1-B Rom1-B merged commit b9375e2 into pluginsGLPI:main Apr 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants