Skip to content

Feat sort on id column linked item tab #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 3, 2025
Merged

Feat sort on id column linked item tab #417

merged 11 commits into from
Apr 3, 2025

Conversation

@Lainow
Copy link
Contributor

@Lainow Lainow commented Apr 1, 2025 •
edited by Rom1-B
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • Feature : !35243
  • Here is a brief description of what this PR does
    Twig to sort on “ID” column in “Order items” tab (DataTable)

Screenshots (if appropriate):

image
image

@Lainow Lainow self-assigned this Apr 1, 2025
@Lainow Lainow requested a review from stonebuzz April 2, 2025 08:52
stonebuzz
stonebuzz requested changes Apr 2, 2025
View reviewed changes
@stonebuzz
Copy link
Contributor

I have this when manufacturer is empty
image

@Lainow Lainow requested a review from stonebuzz April 2, 2025 11:47
stonebuzz
stonebuzz requested changes Apr 2, 2025
View reviewed changes
@stonebuzz stonebuzz requested a review from Rom1-B April 3, 2025 10:16
Rom1-B
Rom1-B requested changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG and it's OK

@stonebuzz stonebuzz requested a review from Rom1-B April 3, 2025 12:10
@Rom1-B Rom1-B merged commit 1a1a0e6 into pluginsGLPI:main Apr 3, 2025
3 checks passed
@RomainLvr RomainLvr mentioned this pull request Apr 16, 2025
Merged
4 tasks
@RomainLvr RomainLvr mentioned this pull request Oct 28, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stonebuzz stonebuzz stonebuzz approved these changes

@Rom1-B Rom1-B Rom1-B approved these changes

Assignees

@Lainow Lainow

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lainow @stonebuzz @Rom1-B