Skip to content

Feat collection#174

Open
stonebuzz wants to merge 3 commits into
mainfrom
feat_collection
Open

Feat collection#174
stonebuzz wants to merge 3 commits into
mainfrom
feat_collection

Conversation

@stonebuzz
Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

Implement collection scope

Screenshots (if appropriate):

@stonebuzz stonebuzz self-assigned this May 22, 2026
@stonebuzz
Copy link
Copy Markdown
Contributor Author

@tolemac

can you try this? =)

@tolemac
Copy link
Copy Markdown
Contributor

tolemac commented May 25, 2026

@stonebuzz some thing wrong writting the field, when I wrote the collection name on textbox and click "Save " button this disappear:

image

I have run the collect and I have wrote $query variable to log and this show something strange:

2026-05-25 07:47:03 [473@SUInventario]
SELECT csd.Description00 as "CSD-Description",
      csd.Domain00 as "CSD-Domain",
      csd.Manufacturer00 as "CSD-Manufacturer",
      csd.Model00 as "CSD-Model",
      csd.Roles00 as "CSD-Roles",
      csd.SystemType00 as "CSD-SystemType",
      csd.UserName00 as "CSD-UserName",
      csd.MachineID as "CSD-MachineID",
      csd.TimeKey as "CSD-TimeKey",
      md.SystemName00 as "MD-SystemName",
      osd.BuildNumber00 as "OSD-BuildNumber",
      osd.Caption00 as "OSD-Caption",
      osd.CSDVersion00 as "OSD-CSDVersion",
      osd.BootDevice00 as "OSD-BootDevice",
      osd.InstallDate00 as "OSD-InstallDate",
      osd.LastBootUpTime00 as "OSD-LastBootUpTime",
      osd.Manufacturer00 as "OSD-Manufacturer",
      osd.Name00 as "OSD-Name",
      osd.Organization00 as "OSD-Organization",
      osd.RegisteredUser00 as "OSD-RegisteredUser",
      osd.TotalVirtualMemorySize00 as "OSD-TotalVirtualMemory",
      osd.TotalVisibleMemorySize00 as "OSD-TotalVisibleMemory",
      osd.Version00 as "OSD-Version",
      pbd.SerialNumber00 as "PBD-SerialNumber",
      pbd.ReleaseDate00 as "PBD-ReleaseDate",
      pbd.Name00 as "PBD-Name",
      pbd.SMBIOSBIOSVersion00 as "PBD-BiosVersion",
      pbd.Version00 as "PBD-Version",
      pbd.Manufacturer00 as "PBD-Manufacturer",
      sdi.User_Name0 as "SDI-UserName",
      sd.SMSID0 as "SD-UUID",
      sd.SystemRole0 as "SD-SystemRole",
      VrS.User_Name0 as "VrS-UserName",
      vWD.LastHWScan as "vWD-LastScan"
      FROM Computer_System_DATA csd
      LEFT JOIN Motherboard_DATA md ON csd.MachineID = md.MachineID
      LEFT JOIN Operating_System_DATA osd ON csd.MachineID = osd.MachineID
      LEFT JOIN v_GS_WORKSTATION_STATUS vWD ON csd.MachineID = vWD.ResourceID
      LEFT JOIN PC_BIOS_DATA pbd ON csd.MachineID = pbd.MachineID
      LEFT JOIN System_DISC sdi ON csd.MachineID = sdi.ItemKey
      LEFT JOIN System_DATA sd ON csd.MachineID = sd.MachineID
      INNER JOIN v_R_System VrS ON csd.MachineID = VrS.ResourceID
      WHERE csd.MachineID is not null and csd.MachineID != '' AND csd.MachineID IN (
      SELECT fcm.ResourceID
      FROM v_FullCollectionMembership fcm
      INNER JOIN v_Collection vc ON fcm.CollectionID = vc.CollectionID
      WHERE vc.Name = N'N/A'
    )2026-05-25 07:47:03 [473@SUInventario]

'N/A' ??

@Rom1-B Rom1-B self-requested a review May 25, 2026 06:40
@tolemac
Copy link
Copy Markdown
Contributor

tolemac commented May 25, 2026

Ok, I have to uninstall the plugin and install it back.
Then the field is created and it works.

The problem with uninstall is that you lost all you configuration, it may be acceptable but it isn't desired :)

It is collection now, I still see it as slow:

2026-05-25 08:37:15 [473@SUInventario]
[Config 1] getDevices OK - 274 files
2026-05-25 08:37:18 [473@SUInventario]
[Config 1] Collect OK for device - 16784352
2026-05-25 08:37:20 [473@SUInventario]
[Config 1] Collect OK for device - 16784363
2026-05-25 08:37:23 [473@SUInventario]
[Config 1] Collect OK for device - 16784374
2026-05-25 08:37:25 [473@SUInventario]
[Config 1] Collect OK for device - 16784381
2026-05-25 08:37:27 [473@SUInventario]
[Config 1] Collect OK for device - 16784383
2026-05-25 08:37:29 [473@SUInventario]
[Config 1] Collect OK for device - 16784385
2026-05-25 08:37:31 [473@SUInventario]
[Config 1] Collect OK for device - 16784474
2026-05-25 08:37:34 [473@SUInventario]
[Config 1] Collect OK for device - 16784513
2026-05-25 08:37:36 [473@SUInventario]
[Config 1] Collect OK for device - 16784519
2026-05-25 08:37:38 [473@SUInventario]
[Config 1] Collect OK for device - 16784520
2026-05-25 08:37:41 [473@SUInventario]
[Config 1] Collect OK for device - 16784522
2026-05-25 08:37:43 [473@SUInventario]
[Config 1] Collect OK for device - 16784525
2026-05-25 08:37:45 [473@SUInventario]
[Config 1] Collect OK for device - 16784535
2026-05-25 08:37:47 [473@SUInventario]
[Config 1] Collect OK for device - 16784552
2026-05-25 08:37:49 [473@SUInventario]
[Config 1] Collect OK for device - 16784557
2026-05-25 08:37:52 [473@SUInventario]
[Config 1] Collect OK for device - 16784560
2026-05-25 08:37:54 [473@SUInventario]
[Config 1] Collect OK for device - 16784568
2026-05-25 08:37:56 [473@SUInventario]

1 devices by each 3 seconds, before multi_sccm PR it was collecting 3 devices by second.

@Rom1-B
Copy link
Copy Markdown
Contributor

Rom1-B commented May 25, 2026

@tolemac
After applying the patch, did you force the installation of the plugin via the CLI:
bin/console plugin:install sccm --force

@Rom1-B
Copy link
Copy Markdown
Contributor

Rom1-B commented May 25, 2026

The issue of multiple connections per collect is a separate topic; I've just created another PR dedicated to it:

@tolemac
Copy link
Copy Markdown
Contributor

tolemac commented May 25, 2026

The issue of multiple connections per collect is a separate topic; I've just created another PR dedicated to it:

Nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants