fix(sdk): adapt to PlugwerkUpdateChecker.checkForUpdates(List<InstalledPluginRef>) signature#43
Merged
bigpuritz merged 1 commit intoMay 13, 2026
Conversation
…edPluginRef>) signature Upstream changed the update-checker SPI from a Map<String, String> of pluginId→version to a List<InstalledPluginRef> (a record carrying pluginId and version). Both example hosts now build the typed list from PF4J's PluginWrapper iterable directly — drops the Collectors.toMap + Map imports in the CLI command, keeps them in the Spring controller (still used for the "updates" view model on the next few lines). Without this change main is red against the current 1.0.0-SNAPSHOT, which also blocks Renovate-driven dependency PRs (e.g. #42) from ever going green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream changed the update-checker SPI signature from
Map<String, String>ofpluginId → versiontoList<InstalledPluginRef>(a typed record carrying the same data). Both example hosts pinned toplugwerk = "1.0.0-SNAPSHOT"fail to compile against the current SNAPSHOT until they adopt the new type.mainis currently red locally (and effectively in CI for any new PR — the last scheduled run onmainsnapshot-pulled an older SDK that still had the Map signature). This blocks every Renovate dependency PR; #42 (slf4j 2.0.17 → 2.0.18) is the immediate trigger but the slf4j bump itself is unrelated to the build break.Changes
plugwerk-java-cli-example/.../UpdateCommand.java— build aList<InstalledPluginRef>from the PF4JPluginWrapperstream; drop now-unusedMap/Collectorsimports.plugwerk-springboot-thymeleaf-example/.../PluginInstalledController.java— same conversion;Map/Collectorsimports stay because the "updates" view model is still a Map a few lines below.Test plan
./gradlew clean build(composite, repo root) — green against the current1.0.0-SNAPSHOT.spotlessApplyran clean in both examples.