Downstream CORE PR #127121

[bouwew]

Summary by CodeRabbit

• Documentation

  • Updated changelog with ongoing improvements from upstream integration.

• Bug Fixes

  • Improved schedule validation for climate mode transitions, ensuring proper error handling when switching to schedule-based modes without an active schedule configured.

[coderabbitai]

Warning

Review limit reached

@bouwew, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 55 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8a0020e9-ab85-40ce-a121-ac4819f65eb3

📥 Commits

Reviewing files that changed from the base of the PR and between 7b28618 and bde4f55.

📒 Files selected for processing (1)

• CHANGELOG.md

📝 Walkthrough

Walkthrough

PR refactors schedule validation in the Plugwise climate component by introducing a centralized _check_for_schedule helper function and updating async_set_hvac_mode to use it, reducing code duplication. Updates changelog to document downstream improvements from Core PR #127121.

Changes

Schedule Validation Refactoring

Layer / File(s)	Summary
Schedule validation helper and hvac mode refactoring custom_components/plugwise/climate.py	Introduces _check_for_schedule helper that raises HomeAssistantError when schedule-based operation is requested without an active schedule and no prior stored schedule. Refactors async_set_hvac_mode to use this helper and compute desired_schedule for mode transitions to AUTO.
Changelog documentation CHANGELOG.md	Adds "## Ongoing" section documenting downstream improvements from Core PR #127121.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• plugwise/plugwise-beta#948: Modifies async_set_hvac_mode and ERROR_NO_SCHEDULE error handling with translation keys in climate.py.
• plugwise/plugwise-beta#1073: Related schedule-transition validation and error behavior in async_set_hvac_mode.
• plugwise/plugwise-beta#945: Modifies schedule-transition logic in async_set_hvac_mode for AUTO mode handling.

Suggested labels

downstreaming

Suggested reviewers

• CoMPaTech

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title 'Downstream CORE PR #127121' is directly related to the changeset, as both the changelog and code changes explicitly reference implementing downstream improvements from Core PR #127121.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch follow-171955

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Line 7: In CHANGELOG.md replace the empty markdown link token []() in the line
"Downstream improvements from Core PR `#127121` via PR []()" with a proper link to
PR `#1074` by changing it to something like "via PR
[`#1074`](https://github.com/<org>/<repo>/pull/1074)" (replace <org>/<repo> with
the actual repository path) so the PR reference is clickable and points to PR
`#1074`.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dbdf7cbe-2025-4d2e-a7b4-459c30178401

📥 Commits

Reviewing files that changed from the base of the PR and between 2be9c13 and 7b28618.

📒 Files selected for processing (2)

• CHANGELOG.md
• custom_components/plugwise/climate.py

[github-actions]

❌ Error while testing for Development HA-core:

⚠️ Warning: Incompatible while testing against dev HA-core.
✔️ Success: No problem with testing against released HA-core.