Skip to content

Conversation

@CoMPaTech
Copy link
Member

@CoMPaTech CoMPaTech commented Apr 29, 2023

Mostly adhere to upstream - kind of redundant with move to ruff, but apparently ruff is missing from poetry config (added in this PR).

Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CoMPaTech
Copy link
Member Author

Lets merge this after #397 and not before (just to be sure we have the strict stuff in place first)

@CoMPaTech CoMPaTech marked this pull request as draft May 4, 2023 07:05
@CoMPaTech
Copy link
Member Author

Undrafting as #397 is now merged

@CoMPaTech CoMPaTech marked this pull request as ready for review May 19, 2023 11:11
@CoMPaTech CoMPaTech requested a review from bouwew May 19, 2023 21:46
Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CoMPaTech CoMPaTech merged commit a3cadd7 into main May 20, 2023
@CoMPaTech CoMPaTech deleted the pylint branch May 20, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants