Skip to content

Quality: improve typing via plugwise v0.31.3 #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
May 15, 2023
Merged

Quality: improve typing via plugwise v0.31.3 #397

merged 52 commits into from
May 15, 2023

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Apr 29, 2023

No description provided.

@bouwew bouwew requested a review from a team as a code owner April 29, 2023 12:36
@bouwew bouwew requested a review from CoMPaTech April 29, 2023 12:36
CoMPaTech
CoMPaTech previously approved these changes Apr 29, 2023
View reviewed changes
@CoMPaTech
Copy link
Member

CoMPaTech commented May 1, 2023

@bouwew please check TODO section in Models wrt existence (and forthcoming improvement of output) of 3a95d72

@CoMPaTech CoMPaTech mentioned this pull request May 1, 2023
Merged
@CoMPaTech
Copy link
Member

CoMPaTech commented May 1, 2023

Adds 4 TODOs wrt the fixtures vs models vs tests

And as predicted by bouwew also re-introduces new mypy failures.

On the bright side, no more manual fixtures, we have a generator for that now in plugwise/python-plugwise#308

@CoMPaTech CoMPaTech added enhancement New feature or request needs_upstreaming Things that are here in -beta but must be upstreamed to HA-core downstreaming Things that are changed on HA-core side and to be applied to -beta smile Smile-related (i.e.networked Plugwise devices) quality labels May 3, 2023
@CoMPaTech CoMPaTech mentioned this pull request May 4, 2023
Merged
@CoMPaTech
Copy link
Member

CoMPaTech commented May 4, 2023

Note on 518c54c still needs max_dhw_temperature change in https://github.com/plugwise/python-plugwise/pull/309/files to be applied (i.e. python-plugwise generates this fixture but test in number-domain fails). prettier should now no longer tinker with the generated fixtures from plugwise/python-plugwise#311

@CoMPaTech CoMPaTech dismissed their stale review May 4, 2023 22:21

Latest dhw not applied now

bouwew
bouwew commented May 5, 2023
View reviewed changes
@CoMPaTech
Copy link
Member

CoMPaTech commented May 5, 2023

max_dhw not introduced in Core PR yet (as that would be new functionality + involve new translations)

@bouwew bouwew changed the title Quality: improve typing via plugwise v0.31.2 Quality: improve typing via plugwise v0.31.3 May 5, 2023
CoMPaTech
CoMPaTech approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-added dhw now (so undoing stale - though it would be approving my own latest commits this way) :)

@CoMPaTech CoMPaTech mentioned this pull request May 5, 2023
Closed
@CoMPaTech
Copy link
Member

CoMPaTech commented May 5, 2023

max_dhw not introduced in Core PR yet (as that would be new functionality + involve new translations)

Marked through #400

CoMPaTech and others added 27 commits May 15, 2023 18:18
@CoMPaTech @bouwew
Correctly name dhw to dhw_setpoint
7c15808
@CoMPaTech @bouwew
Work on todos (breaking tests)
e2c1881
@pre-commit-ci @bouwew
[pre-commit.ci] auto fixes from pre-commit.com hooks
917dcb9 
for more information, see https://pre-commit.ci
@bouwew
Refix dhw_setpoint sensor
e65e947
@bouwew
Fix typo
827c124
@bouwew
Add dhw_setpoint actuator dict to m_adam_heating fixture
bd8dba4
@CoMPaTech @bouwew
Temp revert dhw for mypy; ignoring index
f06d8b2
@CoMPaTech @bouwew
Fugly fix (but working) with 31.3
940a380
@CoMPaTech @bouwew
Try single core-testing
119aa7c
@CoMPaTech @bouwew
Try single core-testing without hassfest
4ff80e7
@CoMPaTech @bouwew
Try single core-testing without hassfest
2f97660
@CoMPaTech @bouwew
Try single core-testing without hassfest
49b6df4
@CoMPaTech @bouwew
Fixture generator issue (true core pr diffing)
fd2dd56
@CoMPaTech @bouwew
Sorted fixtures except m_adam_heating
2a5d56c
@CoMPaTech @bouwew
Restore proper naming
23904c3
@CoMPaTech @bouwew
Rework for max_dhw
e7c57e8
@CoMPaTech @bouwew
Remove fugly ors
4d4e080
@CoMPaTech @bouwew
Fixture newlines
db3e677
@bouwew
Optimize
da09458
@CoMPaTech @bouwew
Remove (now) redundant TypeVar)
538c18b
@CoMPaTech @bouwew
Re-apply prettier, following plugwise-python PR 312
bdcd35e
@pre-commit-ci @bouwew
[pre-commit.ci] auto fixes from pre-commit.com hooks
d5da064 
for more information, see https://pre-commit.ci
@bouwew
Clean translation files
ec2f7d9
@bouwew
Fix unpractical Plugwise-provided resolutions
c50dcaf
@bouwew
Bump to a3
9c7214c
@bouwew
Bump to v0.40.2 release-version
78b6976
@bouwew
Update CHANGELOG
7d81678
@bouwew bouwew merged commit 2b60d01 into main May 15, 2023
@bouwew bouwew deleted the test-typing branch May 15, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoMPaTech CoMPaTech CoMPaTech approved these changes

Assignees

@CoMPaTech CoMPaTech

@bouwew bouwew

Labels

downstreaming Things that are changed on HA-core side and to be applied to -beta enhancement New feature or request needs_upstreaming Things that are here in -beta but must be upstreamed to HA-core quality smile Smile-related (i.e.networked Plugwise devices)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bouwew @CoMPaTech