Skip to content

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Oct 19, 2020

No description provided.

@bouwew bouwew requested review from CoMPaTech and brefra October 19, 2020 18:36
@bouwew bouwew marked this pull request as draft October 19, 2020 18:36
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #16 into main will decrease coverage by 0.08%.
The diff coverage is 82.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   93.85%   93.76%   -0.09%     
==========================================
  Files           5        5              
  Lines        1545     1524      -21     
==========================================
- Hits         1450     1429      -21     
  Misses         95       95              
Impacted Files Coverage Δ
plugwise/smile.py 91.39% <58.06%> (-0.62%) ⬇️
plugwise/constants.py 100.00% <100.00%> (ø)
plugwise/exceptions.py 100.00% <100.00%> (ø)
tests/test_smile.py 97.61% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7acf9...4900eb0. Read the comment docs.

@bouwew bouwew marked this pull request as ready for review October 21, 2020 17:48
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoMPaTech
Copy link
Member

Small downside is the coverage descending because we don't test the stick parts yet (with moving things out as such the coverage decreases)

@bouwew bouwew merged commit 9d84b22 into main Oct 22, 2020
@bouwew bouwew deleted the move_constants branch October 22, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants