Skip to content

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Mar 27, 2022

Yet another multi-thermostat related update/fix.

Also:

  • change detection of invalid schedules
  • improve tracking of last used schedules
  • add test coverage
  • clean up

@bouwew bouwew requested a review from CoMPaTech March 27, 2022 11:05
temp[directive.attrib["time"]] = float(entry.get("setpoint"))
count += 1

LOGGER.debug("HOI 1 %s, %s", count, name)
Copy link
Member

@CoMPaTech CoMPaTech Mar 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug 2x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented.

Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on debugs 👍 otherwise + we should check updating the fixtures when core goes to > 0.16

@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #171 (0d5c276) into main (65c0fbb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2124      2136   +12     
=========================================
+ Hits          2124      2136   +12     
Impacted Files Coverage Δ
plugwise/__init__.py 100.00% <100.00%> (ø)
plugwise/helper.py 100.00% <100.00%> (ø)
plugwise/smile.py 100.00% <100.00%> (ø)
tests/test_smile.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c0fbb...0d5c276. Read the comment docs.

@bouwew bouwew merged commit d14bc2a into main Mar 27, 2022
@bouwew bouwew deleted the fix_set_schedule branch March 27, 2022 15:24
@bouwew bouwew requested a review from CoMPaTech March 27, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants