Skip to content

Merge Exception Class #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bouwew merged 3 commits into from
Oct 23, 2020
Merged

Merge Exception Class #19

bouwew merged 3 commits into from
Oct 23, 2020

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Oct 23, 2020

No description provided.

@bouwew bouwew requested review from CoMPaTech and brefra October 23, 2020 15:05
@codecov
Copy link

codecov bot commented Oct 23, 2020 •
edited
Loading

Codecov Report

Merging #19 into main will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   93.76%   93.69%   -0.08%     
==========================================
  Files           5        5              
  Lines        1524     1506      -18     
==========================================
- Hits         1429     1411      -18     
  Misses         95       95
Impacted Files Coverage Δ
plugwise/constants.py 100.00% <ø> (ø)
plugwise/smile.py 91.39% <ø> (ø)
plugwise/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc36593...2fe137a. Read the comment docs.

CoMPaTech
CoMPaTech reviewed Oct 23, 2020
View reviewed changes
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

brefra
brefra approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@brefra brefra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bouwew bouwew merged commit 713a44d into main Oct 23, 2020
@bouwew bouwew deleted the merge-exceptions branch October 23, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoMPaTech CoMPaTech CoMPaTech approved these changes

@brefra brefra brefra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bouwew @CoMPaTech @brefra