Skip to content

Conversation

@CoMPaTech
Copy link
Member

Following the [dict,dict] -> dict move for writing fixtures during testing in tests

Replace manual written fixtures in plugwise-beta by generated ones.

@CoMPaTech CoMPaTech added bug Something isn't working documentation Improvements or additions to documentation invalid This doesn't seem right python Pull requests that update Python code smile Smile-related (i.e.networked Plugwise devices) labels May 1, 2023
@CoMPaTech CoMPaTech self-assigned this May 1, 2023
@CoMPaTech CoMPaTech requested a review from bouwew as a code owner May 1, 2023 22:22
@CoMPaTech
Copy link
Member Author

And yes I realize the new python script if fugly and can be done better, not after diffing too much json and this late/early in the day. Ties in with plugwise/plugwise-beta@566fbb3 of plugwise/plugwise-beta#397

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #308 (4322dbb) into main (d8855af) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #308   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2624      2629    +5     
=========================================
+ Hits          2624      2629    +5     
Impacted Files Coverage Δ
plugwise/constants.py 100.00% <100.00%> (ø)
plugwise/helper.py 100.00% <100.00%> (ø)
tests/test_smile.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bouwew bouwew requested a review from a team as a code owner May 3, 2023 18:23
@bouwew bouwew merged commit 6778000 into main May 3, 2023
@bouwew bouwew deleted the fake_fixtures branch May 3, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation invalid This doesn't seem right python Pull requests that update Python code smile Smile-related (i.e.networked Plugwise devices)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants