Skip to content

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Jul 26, 2023

All changes:

  • Add NumberType, SelectType and SelectOptionsType Literal typing
  • Add missing fixture for updates (@CoMPaTech )
  • Line up applicable key-names with key-names used in PW-beta / Core Plugwise
  • Adapt relevant test-code and fixtures

@bouwew bouwew requested review from a team and CoMPaTech as code owners July 26, 2023 06:23
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #362 (7c358d6) into main (b20ab8e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #362   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2643      2646    +3     
=========================================
+ Hits          2643      2646    +3     
Files Changed Coverage Δ
tests/test_smile.py 100.00% <ø> (ø)
plugwise/__init__.py 100.00% <100.00%> (ø)
plugwise/constants.py 100.00% <100.00%> (ø)
plugwise/helper.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CoMPaTech CoMPaTech mentioned this pull request Jul 26, 2023
@bouwew bouwew changed the title Improvment: add Types for Number and Select Improvement: add Types for Number and Select Jul 26, 2023
@CoMPaTech CoMPaTech added enhancement New feature or request python Pull requests that update Python code quality labels Jul 26, 2023
@bouwew bouwew merged commit eaf9914 into main Jul 27, 2023
@bouwew bouwew deleted the more_types branch July 27, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python Pull requests that update Python code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants