Skip to content

Improvement: add Types for Number and Select #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 27, 2023
Merged

Improvement: add Types for Number and Select #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
28daed0
Add NumberType and SelectType
bouwew Jul 25, 2023
065116a
Update CHANGELOG
bouwew Jul 25, 2023
3336726
Bump to v0.31.9a0 test-version
bouwew Jul 25, 2023
be7554e
Add missing fixture for updates
CoMPaTech Jul 25, 2023
3bf40d5
Add missing fixture for updates
bouwew Jul 25, 2023
d3b30c9
Update CHANGELOG
bouwew Jul 25, 2023
f12527c
Bump to a1
bouwew Jul 25, 2023
41a66b1
Line up with select-keynames in Core
bouwew Jul 26, 2023
824efb4
Update relevant fixtures
bouwew Jul 26, 2023
b350e1c
Bump to a2
bouwew Jul 26, 2023
93ead08
Add SelectOptionsType
bouwew Jul 26, 2023
e9163c0
Bump to a3
bouwew Jul 26, 2023
44a5e54
Bump to v0.31.9 release-version
bouwew Jul 27, 2023
7c358d6
Update CHANGELOG
bouwew Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
# Changelog

## v0.31.9: Further typing improvements

- Add NumberType, SelectType and SelectOptionsType constants to improve typing further
- Code quality housekeeping

## v0.31.8: Improve typing as per Core PR #96915

## v0.31.8: Improve typing

- Add BinarySensorType, SensorType, SwitchType as per HA Core PR 96915

## v0.31.7: Various small updates

- Repair coverage/fix testing - #294
Expand Down
22 changes: 11 additions & 11 deletions fixtures/adam_heatpump_cooling/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"model": "Lisa",
"name": "Thermostaat BK",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"battery": 55,
"setpoint_high": 18.0,
Expand Down Expand Up @@ -159,7 +159,7 @@
"model": "Lisa",
"name": "Thermostaat DB",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"setpoint_high": 18.0,
"setpoint_low": 4.0,
Expand Down Expand Up @@ -205,14 +205,14 @@
"mac_address": "012345670001",
"model": "Gateway",
"name": "Adam",
"regulation_mode": "cooling",
"regulation_modes": [
"heating",
"off",
"bleeding_cold",
"bleeding_hot",
"cooling"
],
"select_regulation_mode": "cooling",
"sensors": {
"outdoor_temperature": 13.4
},
Expand All @@ -233,7 +233,7 @@
"model": "Lisa",
"name": "Thermostaat JM",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"setpoint_high": 18.0,
"setpoint_low": 4.0,
Expand Down Expand Up @@ -358,7 +358,7 @@
"model": "Lisa",
"name": "Thermostaat SQ",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"setpoint_high": 18.5,
"setpoint_low": 4.0,
Expand Down Expand Up @@ -388,7 +388,7 @@
"model": "Lisa",
"name": "Thermostaat RB",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"setpoint_high": 17.0,
"setpoint_low": 4.0,
Expand All @@ -415,7 +415,7 @@
"model": "ThermoTouch",
"name": "Thermostaat WK",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "Werkdag schema",
"select_schedule": "Werkdag schema",
"sensors": {
"setpoint_high": 21.5,
"setpoint_low": 4.0,
Expand Down Expand Up @@ -444,7 +444,7 @@
"model": "Lisa",
"name": "Thermostaat SJ",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"setpoint_high": 20.5,
"setpoint_low": 4.0,
Expand Down Expand Up @@ -474,7 +474,7 @@
"model": "Lisa",
"name": "Thermostaat KK",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "Werkdag schema",
"select_schedule": "Werkdag schema",
"sensors": {
"battery": 53,
"setpoint_high": 21.5,
Expand Down Expand Up @@ -505,7 +505,7 @@
"model": "Lisa",
"name": "Thermostaat BK1",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "Werkdag schema",
"select_schedule": "Werkdag schema",
"sensors": {
"setpoint_high": 20.5,
"setpoint_low": 4.0,
Expand Down Expand Up @@ -535,7 +535,7 @@
"model": "Lisa",
"name": "Thermostaat BK2",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "Werkdag schema",
"select_schedule": "Werkdag schema",
"sensors": {
"setpoint_high": 20.5,
"setpoint_low": 4.0,
Expand Down
10 changes: 5 additions & 5 deletions fixtures/adam_jip/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"model": "Lisa",
"name": "Slaapkamer",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"battery": 92,
"setpoint": 13.0,
Expand Down Expand Up @@ -93,7 +93,7 @@
"model": "Lisa",
"name": "Kinderkamer",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"battery": 79,
"setpoint": 13.0,
Expand Down Expand Up @@ -139,7 +139,7 @@
"model": "Lisa",
"name": "Logeerkamer",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"battery": 80,
"setpoint": 13.0,
Expand All @@ -165,8 +165,8 @@
"mac_address": "012345670001",
"model": "Gateway",
"name": "Adam",
"regulation_mode": "heating",
"regulation_modes": ["heating", "off", "bleeding_cold", "bleeding_hot"],
"select_regulation_mode": "heating",
"sensors": {
"outdoor_temperature": 24.9
},
Expand Down Expand Up @@ -239,7 +239,7 @@
"model": "Jip",
"name": "Woonkamer",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"battery": 100,
"humidity": 56.2,
Expand Down
12 changes: 6 additions & 6 deletions fixtures/adam_multiple_devices_per_zone/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"model": "Lisa",
"name": "Zone Thermostat Jessie",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "CV Jessie",
"select_schedule": "CV Jessie",
"sensors": {
"battery": 37,
"setpoint": 15.0,
Expand Down Expand Up @@ -239,7 +239,7 @@
"model": "Lisa",
"name": "Zone Lisa WK",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "GF7 Woonkamer",
"select_schedule": "GF7 Woonkamer",
"sensors": {
"battery": 34,
"setpoint": 21.5,
Expand Down Expand Up @@ -311,7 +311,7 @@
"model": "Lisa",
"name": "Zone Lisa Bios",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"battery": 67,
"setpoint": 13.0,
Expand Down Expand Up @@ -345,7 +345,7 @@
"model": "Tom/Floor",
"name": "CV Kraan Garage",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"battery": 68,
"setpoint": 5.5,
Expand Down Expand Up @@ -381,7 +381,7 @@
"model": "Lisa",
"name": "Zone Thermostat Badkamer",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "Badkamer Schema",
"select_schedule": "Badkamer Schema",
"sensors": {
"battery": 92,
"setpoint": 14.0,
Expand All @@ -407,7 +407,7 @@
"mac_address": "012345670001",
"model": "Gateway",
"name": "Adam",
"regulation_mode": "heating",
"select_regulation_mode": "heating",
"sensors": {
"outdoor_temperature": 7.81
},
Expand Down
4 changes: 2 additions & 2 deletions fixtures/adam_onoff_cooling_fake_firmware/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@
"mac_address": "012345670001",
"model": "Gateway",
"name": "Adam",
"regulation_mode": "cooling",
"regulation_modes": [
"heating",
"off",
"bleeding_cold",
"bleeding_hot",
"cooling"
],
"select_regulation_mode": "cooling",
"sensors": {
"outdoor_temperature": 13.4
},
Expand All @@ -72,7 +72,7 @@
"model": "ThermoTouch",
"name": "Thermostaat WK",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"selected_schedule": "Werkdag schema",
"select_schedule": "Werkdag schema",
"sensors": {
"setpoint_high": 21.5,
"setpoint_low": 4.0,
Expand Down
4 changes: 2 additions & 2 deletions fixtures/adam_plus_anna/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"mac_address": "012345670001",
"model": "Gateway",
"name": "Adam",
"regulation_mode": "heating",
"select_regulation_mode": "heating",
"sensors": {
"outdoor_temperature": 11.9
},
Expand All @@ -73,7 +73,7 @@
"model": "ThermoTouch",
"name": "Anna",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "Weekschema",
"select_schedule": "Weekschema",
"sensors": {
"setpoint": 20.5,
"temperature": 20.5
Expand Down
4 changes: 2 additions & 2 deletions fixtures/adam_plus_anna_copy_with_error_domain_added/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"mac_address": "0123456789AB",
"model": "Gateway",
"name": "Adam",
"regulation_mode": "heating",
"select_regulation_mode": "heating",
"vendor": "Plugwise",
"zigbee_mac_address": "0123456789AB"
},
Expand All @@ -70,7 +70,7 @@
"model": "ThermoTouch",
"name": "Anna",
"preset_modes": ["home", "away", "no_frost", "asleep", "vacation"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"setpoint": 20.5,
"temperature": 20.5
Expand Down
6 changes: 3 additions & 3 deletions fixtures/adam_plus_anna_new/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
"model": "ThermoTouch",
"name": "Anna",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "Weekschema",
"select_schedule": "Weekschema",
"sensors": {
"setpoint": 18.5,
"temperature": 18.1
Expand All @@ -153,8 +153,8 @@
"mac_address": "012345670001",
"model": "Gateway",
"name": "Adam",
"regulation_mode": "heating",
"regulation_modes": ["heating", "off", "bleeding_cold", "bleeding_hot"],
"select_regulation_mode": "heating",
"sensors": {
"outdoor_temperature": -1.25
},
Expand All @@ -175,7 +175,7 @@
"model": "Lisa",
"name": "Lisa Badkamer",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "Badkamer",
"select_schedule": "Badkamer",
"sensors": {
"battery": 56,
"setpoint": 15.0,
Expand Down
12 changes: 6 additions & 6 deletions fixtures/adam_zone_per_device/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"model": "Lisa",
"name": "Zone Thermostat Jessie",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "CV Jessie",
"select_schedule": "CV Jessie",
"sensors": {
"battery": 37,
"setpoint": 16.0,
Expand Down Expand Up @@ -239,7 +239,7 @@
"model": "Lisa",
"name": "Zone Lisa WK",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "GF7 Woonkamer",
"select_schedule": "GF7 Woonkamer",
"sensors": {
"battery": 34,
"setpoint": 21.5,
Expand Down Expand Up @@ -311,7 +311,7 @@
"model": "Lisa",
"name": "Zone Lisa Bios",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"battery": 67,
"setpoint": 13.0,
Expand Down Expand Up @@ -345,7 +345,7 @@
"model": "Tom/Floor",
"name": "CV Kraan Garage",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"battery": 68,
"setpoint": 5.5,
Expand Down Expand Up @@ -381,7 +381,7 @@
"model": "Lisa",
"name": "Zone Thermostat Badkamer",
"preset_modes": ["home", "asleep", "away", "vacation", "no_frost"],
"selected_schedule": "Badkamer Schema",
"select_schedule": "Badkamer Schema",
"sensors": {
"battery": 92,
"setpoint": 14.0,
Expand All @@ -407,7 +407,7 @@
"mac_address": "012345670001",
"model": "Gateway",
"name": "Adam",
"regulation_mode": "heating",
"select_regulation_mode": "heating",
"sensors": {
"outdoor_temperature": 7.69
},
Expand Down
2 changes: 1 addition & 1 deletion fixtures/anna_elga_2/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"model": "ThermoTouch",
"name": "Anna",
"preset_modes": ["away", "no_frost", "vacation", "home", "asleep"],
"selected_schedule": "Thermostat schedule",
"select_schedule": "Thermostat schedule",
"sensors": {
"cooling_activation_outdoor_temperature": 26.0,
"cooling_deactivation_threshold": 3.0,
Expand Down
2 changes: 1 addition & 1 deletion fixtures/anna_elga_2_cooling/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"model": "ThermoTouch",
"name": "Anna",
"preset_modes": ["away", "no_frost", "vacation", "home", "asleep"],
"selected_schedule": "Thermostat schedule",
"select_schedule": "Thermostat schedule",
"sensors": {
"cooling_activation_outdoor_temperature": 26.0,
"cooling_deactivation_threshold": 3.0,
Expand Down
2 changes: 1 addition & 1 deletion fixtures/anna_elga_2_schedule_off/all_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"model": "ThermoTouch",
"name": "Anna",
"preset_modes": ["away", "no_frost", "vacation", "home", "asleep"],
"selected_schedule": "None",
"select_schedule": "None",
"sensors": {
"cooling_activation_outdoor_temperature": 26.0,
"cooling_deactivation_threshold": 3.0,
Expand Down
Loading