Integrate creating platform-dicts and improve typing #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoMPaTech
reviewed
Aug 19, 2023
CoMPaTech
reviewed
Aug 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 2697 2685 -12
=========================================
- Hits 2697 2685 -12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CoMPaTech
reviewed
Aug 19, 2023
CoMPaTech
reviewed
Aug 19, 2023
CoMPaTech
reviewed
Aug 19, 2023
Member
|
Please set labels :) |
bouwew
changed the title
After split in DEVICE_MEASUREMENTS and HEATER_CENTRAL_MEASUREMENTS
Member
|
Although this PR is large enough we probably should ensure to promote it to > py3.9, which would require some changes to
|
CoMPaTech
approved these changes
Aug 28, 2023
plugwise/__init__.py
Outdated
| if not device["binary_sensors"]: | ||
| device.pop("binary_sensors") | ||
| if not device["sensors"]: | ||
| device.pop("sensors") |
Member
There was a problem hiding this comment.
We sort of have this twice, should we create a helper function to 'create' within an object instead of deleting afterwards?
plugwise/helper.py
Outdated
| # measurements with states "on" or "off" that need to be passed directly | ||
| if measurement not in ("select_dhw_mode"): | ||
| data[measurement] = format_measure( # type: ignore [literal-required] | ||
| if meas_rn == "select_dhw_mode": |
Member
There was a problem hiding this comment.
With py 3.10 now lets use match case (i.e. switch)
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes: