Refactor into separate paths for actual and legacy Plugwise devices #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 11 19 +8
Lines 2669 3302 +633
==========================================
+ Hits 2669 3302 +633 ☔ View full report in Codecov by Sentry. |
bouwew
force-pushed
the
split_legacy_active
branch
2 times, most recently
from
9d2ff8f to
df0e7e7
Compare
CoMPaTech
approved these changes
Feb 3, 2024
Member
CoMPaTech
left a comment
CoMPaTech
left a comment
There was a problem hiding this comment.
Let's see where the tooling concurs on your commits, not reviewing this as per large refactor. We should merge and see what collateral damage emerges.
Member
|
Nice (and a lot of) work! Kudo's @bouwew |
bouwew
force-pushed
the
split_legacy_active
branch
2 times, most recently
from
a2530ef to
28bd71d
Compare
bouwew
force-pushed
the
split_legacy_active
branch
from
73a8452 to
9e7a8cb
Compare
bouwew
force-pushed
the
split_legacy_active
branch
from
86aa919 to
4fe2784
Compare
bouwew
force-pushed
the
split_legacy_active
branch
from
a25439b to
ad42639
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.