Skip to content

Test under JDK 25, not JDK 25-ea#203

Merged
mernst merged 4 commits intoplume-lib:mainfrom
mernst:java-25-released-2
Oct 12, 2025
Merged

Test under JDK 25, not JDK 25-ea#203
mernst merged 4 commits intoplume-lib:mainfrom
mernst:java-25-released-2

Conversation

@mernst
Copy link
Copy Markdown
Contributor

@mernst mernst commented Oct 12, 2025

Summary by CodeRabbit

  • Chores
    • CI updated to target the stable Java 25 release instead of the early-access build.
    • Consolidated Java matrix to use versions 17, 21, 24, and 25 for builds and tests.
    • Normalized workflow formatting and indentation for consistency.
    • Added a linting suppression to avoid false-positive YAML checks.
    • Minor workflow alignment tweaks to improve maintainability.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 12, 2025

📝 Walkthrough

Walkthrough

Replace early-access Java version entries ('25-ea') with GA '25' in GitHub Actions workflow matrices and normalize list formatting in the workflow YAML files.

Changes

Cohort / File(s) Summary
GitHub Actions CI workflows
.github/workflows/gradle.yml, .github/workflows/gradle-native-compile.yml
Replace 25-ea with 25 in the Java strategy matrices; normalize matrix list formatting and adjust workflow indentation/structure for consistency. Retain/add yamllint disable comment on the on: line in gradle.yml.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title concisely conveys the main change—updating tests to run on JDK 25 instead of the early-access variant—and directly reflects the matrix modifications made to the CI workflows without introducing unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0700e0c and 4794f31.

📒 Files selected for processing (2)
  • .github/workflows/gradle-native-compile.yml (2 hunks)
  • .github/workflows/gradle.yml (2 hunks)
🔇 Additional comments (2)
.github/workflows/gradle.yml (1)

12-36: Ready for GA JDK 25.

Switching the matrix entries to the released 25 alongside 17/21/24 keeps the workflow current, and the existing setup-java configuration will pick up the GA Temurin build without further tweaks.

.github/workflows/gradle-native-compile.yml (1)

12-29: No changes needed for Java 25 in GraalVM setup.

The graalvm/setup-graalvm@v1 action publishes a JDK 25.0.0 release, so the matrix entry is valid.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mernst mernst merged commit 8b8c839 into plume-lib:main Oct 12, 2025
9 checks passed
@mernst mernst deleted the java-25-released-2 branch October 12, 2025 22:34
@coderabbitai coderabbitai Bot mentioned this pull request May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant