Update configuration

[mernst]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@mernst has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between df77942 and 1752358.

📒 Files selected for processing (2)

• build.gradle (4 hunks)
• src/main/java/org/plumelib/options/Options.java (1 hunks)

📝 Walkthrough

Walkthrough

This pull request makes configuration, build infrastructure, and code changes across the project. It introduces a new Claude settings file with command permissions, simplifies CI/CD pipelines by removing javadoc generation and code quality checks from both Gradle and Travis workflows, updates .gitignore with archive format patterns, modernizes Gradle syntax in documentation, refactors build.gradle to migrate publishing coordinates to project properties while adjusting Error Prone disables, adds package and version properties to gradle.properties, and modifies the setArg method in Options.java to preserve trailing empty strings when splitting space-separated list arguments.

Possibly related PRs

• Publish via com.vanniktech.maven.publish #536: Modifies publishing coordinates and metadata in build.gradle using project properties (packageName and version) instead of hard-coded values.
• PMD linting #524: Modifies the setArg method in Options.java with changes to option argument handling logic.

Pre-merge checks and finishing touches

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf23c9d and df77942.

📒 Files selected for processing (9)

• .claude/settings.local.json (1 hunks)
• .github/workflows/gradle.yml (1 hunks)
• .gitignore (1 hunks)
• .travis.yml (1 hunks)
• README-developers.md (1 hunks)
• README.md (2 hunks)
• build.gradle (3 hunks)
• gradle.properties (1 hunks)
• src/main/java/org/plumelib/options/Options.java (1 hunks)

🔇 Additional comments (11)

.gitignore (1)

15-19: LGTM! Good addition of standard archive formats.

The added archive format patterns (*.nar, *.zip, *.tar.gz, *.rar) are appropriate and align with best practices for Java projects.

.claude/settings.local.json (1)

1-13: LGTM! Well-scoped permissions for Claude AI.

The permissions configuration appropriately restricts Claude to safe, build-related commands (./gradlew, java, javac, ls, timeout). This follows the principle of least privilege while enabling necessary development tasks.

README-developers.md (1)

64-64: LGTM! Gradle syntax modernization.

The update from resolutionStrategy.cacheChangingModulesFor 0, "seconds" to resolutionStrategy.cacheChangingModulesFor(0, "minutes") modernizes the syntax to use function-style calls. The unit change from "seconds" to "minutes" has no functional impact since the value is 0.

README.md (2)

38-38: LGTM! Gradle dependency syntax modernization.

The update to use function-style syntax implementation("org.plumelib:options:2.0.3") aligns with modern Gradle conventions and Kotlin DSL style.

---

48-50: LGTM! Gradle task syntax modernization.

The updates to use double-quoted strings and assignment operators (group = "Documentation") align with modern Gradle conventions and improve consistency.

.github/workflows/gradle.yml (1)

26-29: Review comment is incorrect — the workflow has not been simplified.

The git history shows that the current .github/workflows/gradle.yml is identical to the previous version. Both have always contained only:

• java -version
• ./gradlew build

The spotless configuration exists in build.gradle but spotlessCheck is not explicitly called in CI—this appears to be by design (developers likely run it locally or via git hooks). There is no evidence that code quality checks were removed from the workflow, as they were never explicitly part of the CI pipeline.

Likely an incorrect or invalid review comment.

.travis.yml (1)

19-19: ****

The javadoc generation and requireJavadoc checks are NOT removed. The check task depends on both javadoc and requireJavadoc, and ./gradlew build includes the check task by default. The script simplification merely transitions from explicit task names to implicit invocation through Gradle's task dependency chain—no verification scope has been reduced.

Likely an incorrect or invalid review comment.

gradle.properties (1)

1-8: LGTM! Gradle properties correctly externalized and integrated.

All four new properties in gradle.properties are properly configured:

• packageName and version are actively referenced in build.gradle (lines 275-285) for Maven coordinates and repository URLs
• mavenCentralPublishing and signAllPublications are auto-discovered by the gradle-maven-publish-plugin v0.34.0 from gradle.properties, following the plugin's conventions
• No hardcoded version numbers remain in the build configuration

This centralizes version management and publishing configuration as intended.

build.gradle (3)

183-185: Syntactically correct, but in disabled block.

The method call syntax cacheChangingModulesFor(0, "minutes") is correct, but this code is inside a if (false) block (line 175) that never executes. If this is intended to be enabled or the method call is meant as a cleanup, verify that the conditional should remain disabled.

---

272-285: The code changes are valid — no issues found.

The properties are correctly defined in gradle.properties as packageName=options and version=2.0.3. In Gradle, properties defined in gradle.properties are automatically accessible as project properties, making ${project.packageName} and ${project.version} valid references in build.gradle. The refactoring to externalize publishing coordinates and URLs is consistent and follows Gradle best practices.

---

121-127: Clarify intent of Error Prone disables for Java 21+ features.

Lines 126–127 disable checks for StatementSwitchToExpressionSwitch and StringConcatToTextBlock, with comments stating they require Java 12 and 15 respectively. Since this Error Prone block only runs on Java 21+ (where these features are available and mature), the comments don't explain the project's reason for suppressing these checks. Clarify whether the intent is to enforce legacy code style or if the comments are incomplete. Update the comments to explain the actual reason for suppression.