Skip to content

feat: Update workbench evals#3554

Merged
michaeljguarino merged 16 commits into
masterfrom
marcin/prod-4824-update-workbench-eval-draft
May 14, 2026
Merged

feat: Update workbench evals#3554
michaeljguarino merged 16 commits into
masterfrom
marcin/prod-4824-update-workbench-eval-draft

Conversation

@maciaszczykm

@maciaszczykm maciaszczykm commented May 13, 2026

Copy link
Copy Markdown
Member
Zrzut ekranu 2026-05-14 o 10 40 54
Zrzut ekranu 2026-05-14 o 10 45 13
Zrzut ekranu 2026-05-14 o 10 44 50

@linear

linear Bot commented May 13, 2026

Copy link
Copy Markdown

PROD-4824

@maciaszczykm maciaszczykm added the enhancement New feature or request label May 13, 2026
@maciaszczykm maciaszczykm marked this pull request as ready for review May 14, 2026 08:47
@maciaszczykm maciaszczykm requested a review from a team May 14, 2026 08:47
@greptile-apps

greptile-apps Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the workbench evaluations workflow with URL-based selection, new shared components, and navigation improvements. Selected eval results are now tracked in the URL (/evals/:evalResultId), enabling deep-linking, and a grade badge is added to the jobs table for quick navigation to eval details.

  • URL-driven eval selectionWorkbenchEvals replaces local state with useParams and a redirect effect, using replace: true so history is not polluted; route definitions in workbenchesRoutes.tsx are updated accordingly.
  • New shared componentsWorkbenchEvalGradeBadge (correctly guards against grade 0 with != null), WorkbenchEvalSkillButton (popup for generating skills from an eval), and WorkbenchStartedJobPanel (extracted from FlowWorkbenchJobLauncher, now also surfaces query errors).
  • WorkbenchJobTiny GraphQL fragment updated to include evalResult { id, grade }, covering all new table and badge usages.

Confidence Score: 5/5

Safe to merge — changes are additive UI/routing improvements with no data-mutation risk.

All new components follow existing patterns, GraphQL fragments are correctly extended, the evalResult.grade != null guard properly handles grade 0, and the URL-based navigation redirect uses replace: true to avoid history pollution. No functional regressions were identified.

No files require special attention.

Important Files Changed

Filename Overview
assets/src/components/workbenches/workbench/evals/WorkbenchEvals.tsx Migrates selected eval tracking from local state to URL params, with a useEffect that redirects to the first result when none is specified — logic is sound, no loop risk, and navigation uses replace: true.
assets/src/components/workbenches/common/WorkbenchEvalSkillButton.tsx New component for creating workbench skills from an eval result; uses a ref to detect eval ID changes on open and reset state correctly.
assets/src/components/workbenches/common/WorkbenchStartedJobPanel.tsx Code extracted from FlowWorkbenchJobLauncher into a reusable component; now also surfaces queryError that was silently swallowed in the original implementation.
assets/src/components/workbenches/common/WorkbenchEvalGradeBadge.tsx New shared badge component for eval grades; handles grade 0 correctly.
assets/src/components/workbenches/workbench/WorkbenchJobsTable.tsx Adds eval grade badge to the jobs table using evalResult.grade != null guard (correctly handles grade 0), navigating to getWorkbenchEvalResultAbsPath on click.
assets/src/routes/workbenchesRoutes.tsx Adds a new evals/:evalResultId child route alongside the existing evals route, enabling deep-linking to a specific eval result.
assets/src/graph/workbench.graphql Adds evalResult { id, grade } to WorkbenchJobTiny fragment and adds WorkbenchEvalSkill mutation; fragment fields correctly cover all new usages in the UI.

Reviews (2): Last reviewed commit: "fix review finding" | Re-trigger Greptile

Comment thread assets/src/components/workbenches/workbench/WorkbenchJobsTable.tsx Outdated
@maciaszczykm

Copy link
Copy Markdown
Member Author

@greptileai

@michaeljguarino michaeljguarino merged commit 2b1770f into master May 14, 2026
14 checks passed
@michaeljguarino michaeljguarino deleted the marcin/prod-4824-update-workbench-eval-draft branch May 14, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants