feat: Update workbench evals#3554
Conversation
Greptile SummaryThis PR updates the workbench evaluations workflow with URL-based selection, new shared components, and navigation improvements. Selected eval results are now tracked in the URL (
Confidence Score: 5/5Safe to merge — changes are additive UI/routing improvements with no data-mutation risk. All new components follow existing patterns, GraphQL fragments are correctly extended, the evalResult.grade != null guard properly handles grade 0, and the URL-based navigation redirect uses replace: true to avoid history pollution. No functional regressions were identified. No files require special attention.
|
| Filename | Overview |
|---|---|
| assets/src/components/workbenches/workbench/evals/WorkbenchEvals.tsx | Migrates selected eval tracking from local state to URL params, with a useEffect that redirects to the first result when none is specified — logic is sound, no loop risk, and navigation uses replace: true. |
| assets/src/components/workbenches/common/WorkbenchEvalSkillButton.tsx | New component for creating workbench skills from an eval result; uses a ref to detect eval ID changes on open and reset state correctly. |
| assets/src/components/workbenches/common/WorkbenchStartedJobPanel.tsx | Code extracted from FlowWorkbenchJobLauncher into a reusable component; now also surfaces queryError that was silently swallowed in the original implementation. |
| assets/src/components/workbenches/common/WorkbenchEvalGradeBadge.tsx | New shared badge component for eval grades; handles grade 0 correctly. |
| assets/src/components/workbenches/workbench/WorkbenchJobsTable.tsx | Adds eval grade badge to the jobs table using evalResult.grade != null guard (correctly handles grade 0), navigating to getWorkbenchEvalResultAbsPath on click. |
| assets/src/routes/workbenchesRoutes.tsx | Adds a new evals/:evalResultId child route alongside the existing evals route, enabling deep-linking to a specific eval result. |
| assets/src/graph/workbench.graphql | Adds evalResult { id, grade } to WorkbenchJobTiny fragment and adds WorkbenchEvalSkill mutation; fragment fields correctly cover all new usages in the UI. |
Reviews (2): Last reviewed commit: "fix review finding" | Re-trigger Greptile
Uh oh!
There was an error while loading. Please reload this page.