feat: cloud-query lua tool#3585
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Greptile SummaryThis PR adds a
Confidence Score: 3/5The Lua sandbox exposes The core issue is that
|
| Filename | Overview |
|---|---|
| go/cloud-query/internal/tools/lua/runner.go | New Lua sandbox runner; dofile/loadfile from OpenBase contradict the documented "no filesystem" guarantee, and the post-execution timeout path is unreachable dead code |
| go/cloud-query/internal/service/toolquery.go | New RunLua RPC handler with standard nil/empty validation; overall structure consistent with existing handlers |
| go/cloud-query/internal/tools/lua/runner_test.go | Good sandbox test coverage; missing a test case for dofile/loadfile access which is not blocked by the sandbox |
| go/cloud-query/api/proto/toolquery.proto | Adds RunLuaInput/RunLuaOutput messages and RunLua RPC; straightforward and consistent with existing proto patterns |
| go/cloud-query/go.mod | Adds gopher-lua and polly dependencies; indirect deps look correct |
Reviews (1): Last reviewed commit: "cloud-query lua tool" | Re-trigger Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Test Plan
Test environment: https://console.your-env.onplural.sh/
Checklist
Plural Flow: console