Skip to content

cleanup deploy.hcl sha#343

Merged
zreigz merged 1 commit into
mainfrom
delete-deploy-hcl
Feb 21, 2023
Merged

cleanup deploy.hcl sha#343
zreigz merged 1 commit into
mainfrom
delete-deploy-hcl

Conversation

@zreigz
Copy link
Copy Markdown
Member

@zreigz zreigz commented Feb 21, 2023

Summary

plural destroy should not delete deploy.hcl for each app, just clean up the sha field in this file

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@zreigz zreigz added the enhancement New feature or request label Feb 21, 2023
Comment thread pkg/wkspace/actions.go
if err != nil {
return err
}
if err := editor.Update("step.*.sha", ""); err != nil {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoa this is pretty cool

@zreigz zreigz merged commit 66ef55d into main Feb 21, 2023
@zreigz zreigz deleted the delete-deploy-hcl branch February 28, 2023 12:11
michaeljguarino pushed a commit that referenced this pull request Aug 28, 2024
kinjalh pushed a commit that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants