Skip to content

Enhance OS compatibility check in PluginConfig class #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plusplusoneplusplus merged 1 commit into from
Jun 17, 2025
Merged

Enhance OS compatibility check in PluginConfig class #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mcp_tools/plugin_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,10 @@ def is_os_enabled(self, os: Optional[str]) -> bool:

os_lower = os.lower()

# Tools with os_type="all" should always be compatible
if os_lower == "all":
return True

# If enabled_os is empty, all OS types are enabled
if not self.enabled_os:
return True
Expand Down
6 changes: 3 additions & 3 deletions mcp_tools/tests/test_plugin_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ def test_os_config_default(monkeypatch):
assert cfg.enabled_os == {"non-windows"}
assert not cfg.is_os_enabled("windows")
assert cfg.is_os_enabled("non-windows")
assert not cfg.is_os_enabled("all")
assert cfg.is_os_enabled("all") # Tools with os_type="all" are always compatible
assert cfg.is_os_enabled(None) # None is always enabled for backward compatibility


Expand All @@ -636,7 +636,7 @@ def test_os_config_specific_os(monkeypatch):
assert cfg.enabled_os == {"windows", "non-windows"}
assert cfg.is_os_enabled("windows")
assert cfg.is_os_enabled("non-windows")
assert not cfg.is_os_enabled("all")
assert cfg.is_os_enabled("all") # Tools with os_type="all" are always compatible


def test_os_config_single_os(monkeypatch):
Expand All @@ -646,7 +646,7 @@ def test_os_config_single_os(monkeypatch):
assert cfg.enabled_os == {"windows"}
assert cfg.is_os_enabled("windows")
assert not cfg.is_os_enabled("non-windows")
assert not cfg.is_os_enabled("all")
assert cfg.is_os_enabled("all") # Tools with os_type="all" are always compatible


def test_os_config_case_insensitive(monkeypatch):
Expand Down