Skip to content

Add about page and navigation link#26

Merged
plx merged 1 commit intomainfrom
plx/add-about-page
Mar 15, 2026
Merged

Add about page and navigation link#26
plx merged 1 commit intomainfrom
plx/add-about-page

Conversation

@plx
Copy link
Owner

@plx plx commented Mar 15, 2026

Summary

  • Add /about page with site description and social links
  • Add "about" entry to header navigation, following existing a11y patterns (aria-current, semantic list items)

Notes

The about page content is minimal — site description + connect links. You'll likely want to personalize the bio section.

Test plan

  • Verify /about page loads and renders correctly
  • Verify navigation shows "about" link on all pages
  • Verify aria-current="page" activates on /about

🤖 Generated with Claude Code

Add /about page with site description and social links.
Add "about" entry to the header navigation bar.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Contributor

PR Validation ✅

All checks passed! Ready for review.

Checks Performed:

✓ Linting
✓ Spell check (source)
✓ Type checking & Build
✓ Spell check (HTML)
✓ Internal link validation
✓ Artifact upload

This is a complete dry-run of the deployment process, ensuring your changes will deploy successfully when merged.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e29688fe4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

import { SITE, SOCIALS } from "@consts";
import { getHomeOGData } from "@lib/opengraph";

const ogData = getHomeOGData(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Generate page-specific OpenGraph metadata

Using getHomeOGData here causes /about to publish homepage OpenGraph fields (title/description are hardcoded in src/lib/opengraph.ts), and Head.astro prefers provided ogData over the page props, so sharing /about will show homepage preview text instead of About-page metadata. This impacts SEO/social previews specifically when the About URL is crawled or shared.

Useful? React with 👍 / 👎.

@claude
Copy link

claude bot commented Mar 15, 2026

PR Review: Add about page and navigation link

Overall this is a clean, well-structured addition. A few observations:


Header.astro looks good. The new nav entry mirrors the existing separator+link pattern exactly. aria-current using startsWith("/about") is correct and consistent with all other nav items.


about.astro minor issues:

1. Semantic: <article> in the Connect section

The Connect section wraps its content in <article>, but <article> is for self-contained compositions that could stand alone. A <div> is more semantically correct here. The <article class="prose ..."> in the Dispatches section is a closer call (prose styling is the rationale), but a <div> is cleaner there too.

2. Content duplicated from homepage

The site description blurb and the Connect section both duplicate content already on index.astro. The PR notes this is intentional, but updates will need to be made in two places. Consider extracting the blurb to a constant in @consts to keep them in sync — low priority.

3. getHomeOGData on a non-home page

This works and mirrors index.astro exactly. The function name implies it is home-specific though — worth verifying it does not generate any home-specific OG metadata. If it is actually general-purpose, a rename would improve clarity. Not a blocker.


No issues with: heading hierarchy (h1 then h2 — correct, and better than the h5 on the index page), animate class usage, aria-label on social links, or aria-hidden="true" on the separator li.


Verdict: Ready to merge. The <article> to <div> swap in the Connect section is the only thing worth a quick fix.

@plx plx mentioned this pull request Mar 15, 2026
4 tasks
@plx plx merged commit e0a2b5a into main Mar 15, 2026
5 checks passed
@plx plx deleted the plx/add-about-page branch March 15, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant