Skip to content

Document subcommands module and fix architecture layout#4

Merged
plx merged 2 commits intomainfrom
plx/doc-audit
Apr 30, 2026
Merged

Document subcommands module and fix architecture layout#4
plx merged 2 commits intomainfrom
plx/doc-audit

Conversation

@plx
Copy link
Copy Markdown
Owner

@plx plx commented Apr 18, 2026

Summary

  • Audited human-facing documentation for accuracy: README.md and CLI help strings match the code, and #![warn(missing_docs)] already enforces rustdoc coverage on public items.
  • Fixed docs/architecture.md — the repo-layout diagram was missing the entire src/subcommands/ directory, and the CLI-parsing pipeline step did not mention dispatch to subcommand handlers.
  • Added module-level //! doc comments to src/subcommands/{mod,copy,list,info,validate}.rs, which were the only source files without a file-level comment.

Test plan

  • cargo build
  • cargo doc --no-deps (no warnings)
  • Verified waft --help and each subcommand's --help match the documented flags

plx and others added 2 commits April 29, 2026 15:21
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The architecture doc and module-level docs were written before the gix
migration (PR #3) and the worktreeinclude-modes feature (PR #5). This
re-checks them against the current code surface:

- Decision #1: "Git CLI is authoritative" reframed as the GitBackend
  trait with two implementations (GitGix default, GitCli via
  WAFT_GIT_BACKEND=cli) backed by parity tests.
- Decision #2: per-directory semantics are now one of three pluggable
  engines (claude-2026-04 default, git, wt-0.39); the per-directory
  discussion lives in its own section.
- Repo layout adds config.rs, policy_filter.rs, worktreeinclude_engine.rs,
  the new test files, and the planning docs.
- Command pipeline updated to 9 stages: policy resolution, select_candidates
  dispatch, post-selection policy filter.
- README eligibility rule covers when_missing=all-ignored and the
  exclusion sets; the nested .worktreeinclude paragraph leads with the
  default (root-only) behavior.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@plx plx merged commit d5ef32d into main Apr 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant