Handle trailing NULLs after %%EOF#136
Open
eli-collins wants to merge 2 commits intopmaupin:masterfrom
Open
Conversation
Modified PdfReader's EOF detector to ignore trailing NULLs in addition to whitespace.
Owner
|
Thanks for the patch! I have no problem with stripping trailing nulls, but to avoid any chance of regression, I would prefer not to stop stripping other characters which the current version would strip. Python's definition of whitespace includes vertical tabs and form feeds, so I think the characters to be stripped should include '\x0b\x0c' |
Author
|
Sigh. I'm always forgetting those. I'm glad you caught that! |
|
We had the same issue with any file printed from Chrome on Windows 10. This will be a great patch. Thanks! (BTW, would it make sense to strip everything after the final %%EOF?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a print printer whose output appends a bunch of NULL characters after the %%EOF marker in it's PDFs. This tweaks PdfReader's EOF detector to ignore those like it does trailing whitespace.