chore: remove public methods from SourceManager #6229
Conversation
SourceManager itself is package-private, so the effective visibility of those methods won't be public anyway. Fixes pmd#5701
|
Compared to main: (comment created at 2025-11-13 16:13:53+00:00 for 7764d1d) |
|
Note: This only fixes the instances in SourceManager. Running #6231 against PMD's codebase reveals a lot more instances (~ 100 in pmd-core). |
| ### 🚀️ New and noteworthy | ||
|
|
||
| ### 🐛️ Fixed Issues | ||
| * general |
There was a problem hiding this comment.
this seems purely internal. As a user, I wouldn't need to see this in the release notes
There was a problem hiding this comment.
yes, maybe we can move it down under "internal/maintenance", it's not important for users. But I'd like to have the release notes complete and match what we track with the milestone.
|
I'm going to merge this for 7.19.0, assuming this is ok. |
2 participants
Describe the PR
SourceManager itself is package-private, so the effective visibility of those methods won't be public anyway.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)