prov/off_s - SHARP provider scaffolding

[grom72]

Signed-off-by: Tomasz Gromadzki tomasz.gromadzki@intel.com

Requires #2

---

This change is 

[ldorau]

Reviewed all commit messages.
Reviewable status: 0 of 30 files reviewed, all discussions resolved

[ldorau]

Reviewed 2 of 8 files at r1, 6 of 24 files at r3, 1 of 14 files at r5, 2 of 4 files at r6, all commit messages.
Reviewable status: 11 of 34 files reviewed, 2 unresolved discussions (waiting on @grom72)

---

include/ofi_sharp.h line 43 at r6 (raw file):

#include <ofi_atom.h>
#include <ofi_proto.h>

It seems they all are not needed here ...

Code quote:

#include "config.h"

#include <stdint.h>
#include <stddef.h>
#include <sys/un.h>

#include <ofi_atom.h>
#include <ofi_proto.h>
#include <ofi_mem.h>
#include <ofi_rbuf.h>
#include <ofi_tree.h>
#include <ofi_hmem.h>

#include <rdma/providers/fi_prov.h>

#include "ofi_coll.h"

---

include/rdma/fi_domain.h line 252 at r6 (raw file):

	FI_SCATTER,
	FI_GATHER,
	FI_COLLECTIVE_OP_MAX, //must be always the last value of this enum

MAX /* must be always the last value of this enum */

Code quote:

MAX, //must be always the last value of this enum

[ldorau]

Reviewed 6 of 36 files at r7, 1 of 1 files at r8, 15 of 30 files at r9, all commit messages.
Reviewable status: 22 of 37 files reviewed, 6 unresolved discussions (waiting on @grom72)

---

prov/rxm/src/rxm_ep.c line 394 at r9 (raw file):

	//FI_PEER flag is used to force util_coll context 
	//where fi_join() is called from offload provider

1. C++ style comment
2. space at the end

Code quote:

	//FI_PEER flag is used to force util_coll context
	//where fi_join() is called from offload provider

---

prov/rxm/src/rxm_ep.c line 402 at r9 (raw file):

		if (ret)
			goto err_util_coll;
		// It is collective offload provider responsibility to store util_coll provider mc

.

Code quote:

// It is collective offload provider responsibility to store util_coll provider mc

---

prov/rxm/src/rxm_msg.c line 818 at r9 (raw file):

				   rxm_ep_sar_calc_segs_cnt(rxm_ep, data_len));
	} else {
rndv_send:

Empty line before label, not after

Code quote:

	} else {
rndv_send:

		ret = rxm_alloc_rndv_buf(rxm_ep, rxm_conn, context,

---

prov/sharp/configure.m4 line 1 at r9 (raw file):

dnl Configury specific to the libfabric sharp provider

?

Code quote:

Configury

[ldorau]

Reviewable status: 22 of 37 files reviewed, 7 unresolved discussions (waiting on @grom72)

---

prov/sharp/src/sharp_domain.c line 124 at r10 (raw file):

	/// mapped to int sharp_coll_finalize(struct sharp_coll_context *context);
	ret = ofi_domain_close(&domain->util_domain);
	if (ret)

Memory leak - domain is not freed.

Code quote:

	if (ret)
		return ret;

[ldorau]

Reviewable status: 22 of 37 files reviewed, 6 unresolved discussions (waiting on @grom72)

---

prov/sharp/src/sharp_domain.c line 124 at r10 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

Memory leak - domain is not freed.

Maybe not a memory leak - if .close checks for return code and retries - I hope it does so ;-)

[grom72]

see #8