Update cmake_build_type handling and switch default to RelWithDebInfo

[lukaszstolarczuk]

This change is 

[codecov]

Codecov Report

Merging #1044 (003a6e0) into master (a10ad3b) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
+ Coverage   93.99%   94.07%   +0.08%     
==========================================
  Files          48       48              
  Lines        4711     4746      +35     
==========================================
+ Hits         4428     4465      +37     
+ Misses        283      281       -2     

Flag	Coverage Δ
tests_clang_debug_cpp17	93.41% <ø> (+0.22%)	⬆️
tests_gcc_debug	92.05% <ø> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
include/libpmemobj++/condition_variable.hpp	73.80% <0.00%> (-2.39%)	⬇️
include/libpmemobj++/string_view.hpp	100.00% <0.00%> (ø)
...ude/libpmemobj++/container/concurrent_hash_map.hpp	93.88% <0.00%> (+0.15%)	⬆️
include/libpmemobj++/transaction.hpp	82.56% <0.00%> (+0.91%)	⬆️
...libpmemobj++/detail/enumerable_thread_specific.hpp	100.00% <0.00%> (+1.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10ad3b...003a6e0. Read the comment docs.

[igchor]

Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, all discussions resolved

[KFilipek]

Reviewed 3 of 3 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

---

CMakeLists.txt, line 57 at r2 (raw file):

	message(STATUS "CMAKE_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
	if(NOT CMAKE_BUILD_TYPE IN_LIST predefined_build_types)
		message(WARNING "Unusual build type was set, please make sure it's proper one. "

Unusual is MinSizeRel, but something from out of the list is definitely "Wrong build type"

[lukaszstolarczuk]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KFilipek)

---

CMakeLists.txt, line 57 at r2 (raw file):

Previously, KFilipek (Krzysztof Filipek) wrote…

Unusual is MinSizeRel, but something from out of the list is definitely "Wrong build type"

I'd rather disagree. I understand your point, but:

• CMake may extend the list of supported build types, and I'd rather be angry if CMake (of any project) forced fail me ;)
• anyone can extend this list and define their own build type with their own compiler flags

This warning is rather for people who mistyped some name, or use uppercase where there isn't... something like this.

[karczex]

Reviewed 3 of 3 files at r1, 1 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KFilipek)

[KFilipek]

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

---

CMakeLists.txt, line 57 at r2 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

I'd rather disagree. I understand your point, but:

• CMake make extend the list of supported build types, and I'd rather be angry if CMake (of any project) forced fail me ;)
• anyone can extend this list and define their own build type with their own compiler flags

This warning is rather for people who mistyped some name, or use uppercase where there isn't... something like this.

Explained in offline discussion

[igchor]

Reviewed 1 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)