Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

docker: fix packages deps#1050

Merged
lukaszstolarczuk merged 3 commits intopmem:masterfrom
lukaszstolarczuk:fix-packages-deps
Feb 24, 2021
Merged

docker: fix packages deps#1050
lukaszstolarczuk merged 3 commits intopmem:masterfrom
lukaszstolarczuk:fix-packages-deps

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Feb 24, 2021 •
edited by marcinslusarz
Loading

mainly it's required because I've misplaced installation of Coverity Deps - they should be on Ubuntu 20.04

BTW:

  • I propose to quickly fix (for now) Fedora Rawhide image using valgrind package from upstream
  • it's required by pmreorder to have python3, and it's probably by accident we have it already in the image

This change is Reviewable

@lukaszstolarczuk
docker: add python3 package as PMDK dependency
d1b9624 
it's required by pmreorder, which we install with PMDK.
@lukaszstolarczuk
docker: Coverity dependency is required on Ubuntu 20.04 not Fedora's
ad7094e
@lukaszstolarczuk
docker: install valgrind from an upstream package on Fedora Rawhide
cd28a59 
it's because of an automake bug in Fedora Rawhide docker image:
https://bugzilla.redhat.com/show_bug.cgi?id=1903527
I hope it's temporary change and it will be fixed on next release.
igchor
igchor approved these changes Feb 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

karczex
karczex reviewed Feb 24, 2021
View reviewed changes
Copy link
Copy Markdown

@karczex karczex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2021 •
edited
Loading

Codecov Report

Merging #1050 (cd28a59) into master (5c311e3) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1050      +/-   ##
==========================================
+ Coverage   94.10%   94.16%   +0.06%     
==========================================
  Files          48       48              
  Lines        4712     4711       -1     
==========================================
+ Hits         4434     4436       +2     
+ Misses        278      275       -3
Flag Coverage Δ
tests_clang_debug_cpp17 93.68% <ø> (+0.19%) ⬆️
tests_gcc_debug 92.08% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/condition_variable.hpp 73.80% <0.00%> (-2.39%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.67% <0.00%> (+0.31%) ⬆️
...libpmemobj++/detail/enumerable_thread_specific.hpp 100.00% <0.00%> (+1.08%) ⬆️
include/libpmemobj++/detail/life.hpp 100.00% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c311e3...cd28a59. Read the comment docs.

KFilipek
KFilipek reviewed Feb 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

@lukaszstolarczuk lukaszstolarczuk merged commit a10ad3b into pmem:master Feb 24, 2021
@lukaszstolarczuk lukaszstolarczuk deleted the fix-packages-deps branch February 24, 2021 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@KFilipek KFilipek KFilipek left review comments

@karczex karczex karczex left review comments

@igchor igchor igchor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukaszstolarczuk @KFilipek @karczex @igchor