This repository was archived by the owner on Mar 22, 2023. It is now read-only.
Add extra Windows CI job#1053
Merged
lukaszstolarczuk merged 2 commits intopmem:masterfrom Mar 10, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
==========================================
- Coverage 94.30% 94.19% -0.11%
==========================================
Files 48 48
Lines 4720 4720
==========================================
- Hits 4451 4446 -5
- Misses 269 274 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
igchor
approved these changes
Mar 9, 2021
Contributor
igchor
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
KFilipek
reviewed
Mar 10, 2021
Contributor
KFilipek
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and warn about missing curses lib only once in the build (it's repeated several times in Windows build).
This change is