Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Add extra Windows CI job#1053

Merged
lukaszstolarczuk merged 2 commits intopmem:masterfrom
lukaszstolarczuk:add-extra-win-CI
Mar 10, 2021
Merged

Add extra Windows CI job#1053
lukaszstolarczuk merged 2 commits intopmem:masterfrom
lukaszstolarczuk:add-extra-win-CI

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Mar 8, 2021

and warn about missing curses lib only once in the build (it's repeated several times in Windows build).


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2021

Codecov Report

Merging #1053 (aab7724) into master (fbe4025) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
- Coverage   94.30%   94.19%   -0.11%     
==========================================
  Files          48       48              
  Lines        4720     4720              
==========================================
- Hits         4451     4446       -5     
- Misses        269      274       +5     
Flag Coverage Δ
tests_clang_debug_cpp17 93.55% <ø> (-0.12%) ⬇️
tests_gcc_debug 92.11% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/condition_variable.hpp 73.80% <0.00%> (-4.77%) ⬇️
...libpmemobj++/detail/enumerable_thread_specific.hpp 98.91% <0.00%> (-1.09%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.20% <0.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe4025...aab7724. Read the comment docs.

Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved

Copy link
Copy Markdown
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

@lukaszstolarczuk lukaszstolarczuk merged commit eca8f5f into pmem:master Mar 10, 2021
@lukaszstolarczuk lukaszstolarczuk deleted the add-extra-win-CI branch March 10, 2021 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants