Clean docker images

[lukaszstolarczuk]

It's a continuation of #1031

Preview with all OSes enabled:
https://github.com/lukaszstolarczuk/libpmemobj-cpp/actions/runs/662006158
new preview: https://github.com/lukaszstolarczuk/libpmemobj-cpp/actions/runs/667687106

FYI, Fedora Rawhide is using PMDK and Valgrind installed using dnf.

---

This change is 

[igchor]

Reviewed 11 of 15 files at r1.
Reviewable status: 11 of 15 files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

[codecov]

Codecov Report

Merging #1059 (03ef46c) into master (2d0c864) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
+ Coverage   94.09%   94.13%   +0.04%     
==========================================
  Files          48       48              
  Lines        4742     4742              
==========================================
+ Hits         4462     4464       +2     
+ Misses        280      278       -2     

Flag	Coverage Δ
tests_clang_debug_cpp17	93.35% <ø> (-0.23%)	⬇️
tests_gcc_debug	92.19% <ø> (+0.29%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
include/libpmemobj++/container/vector.hpp	92.30% <0.00%> (ø)
...ude/libpmemobj++/container/concurrent_hash_map.hpp	94.35% <0.00%> (ø)
include/libpmemobj++/transaction.hpp	80.64% <0.00%> (+0.80%)	⬆️
include/libpmemobj++/condition_variable.hpp	76.19% <0.00%> (+2.38%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0c864...03ef46c. Read the comment docs.

[KFilipek]

Reviewed 4 of 15 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

[karczex]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @lukaszstolarczuk)

---

utils/docker/images/Dockerfile.centos-8, line 94 at r1 (raw file):

	${TESTS_DEPS} \
	${MISC_DEPS} \
 && dnf clean all

As I can see, you update and clean dnf cache here and there little bit inconsistently, so you end up with bigger layers to download.

---

utils/docker/images/Dockerfile.debian-unstable, line 72 at r1 (raw file):

	pkg-config \
	sudo \
	whois"

Why we need this pkg in container?

---

utils/docker/images/Dockerfile.opensuse-leap-latest, line 92 at r1 (raw file):

# Clean the package cache
RUN zypper clean all

Cleaning in separate layer doesn't provide any benefit

[lukaszstolarczuk]

Reviewable status: 9 of 16 files reviewed, 3 unresolved discussions (waiting on @igchor and @karczex)

---

utils/docker/images/Dockerfile.centos-8, line 94 at r1 (raw file):

Previously, karczex (Paweł Karczewski) wrote…

As I can see, you update and clean dnf cache here and there little bit inconsistently, so you end up with bigger layers to download.

it's not what I did, we have it for a long time, but good point.

---

utils/docker/images/Dockerfile.debian-unstable, line 72 at r1 (raw file):

Previously, karczex (Paweł Karczewski) wrote…

Why we need this pkg in container?

I believe it delivers 'mkpasswd' command (used for user creation)

---

utils/docker/images/Dockerfile.opensuse-leap-latest, line 92 at r1 (raw file):

Previously, karczex (Paweł Karczewski) wrote…

Cleaning in separate layer doesn't provide any benefit

Done.

[karczex]

Reviewable status: 9 of 16 files reviewed, all discussions resolved (waiting on @igchor)