Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

tests: fix sign-conversion warning in helpers_test#1072

Merged
lukaszstolarczuk merged 1 commit intopmem:masterfrom
igchor:fix_helpers_test
May 5, 2021
Merged

tests: fix sign-conversion warning in helpers_test#1072
lukaszstolarczuk merged 1 commit intopmem:masterfrom
igchor:fix_helpers_test

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented May 5, 2021

This change is Reviewable

Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igchor)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2021

Codecov Report

Merging #1072 (b966987) into master (a2cb574) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
- Coverage   94.23%   94.02%   -0.22%     
==========================================
  Files          48       48              
  Lines        4751     4751              
==========================================
- Hits         4477     4467      -10     
- Misses        274      284      +10     
Flag Coverage Δ
tests_clang_debug_cpp17 93.48% <ø> (-0.18%) ⬇️
tests_gcc_debug 91.71% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/condition_variable.hpp 61.90% <0.00%> (-16.67%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.35% <0.00%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2cb574...b966987. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk merged commit efa2413 into pmem:master May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants