Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Revert "gha: temporarily disable codecov"#1085

Merged
igchor merged 1 commit intopmem:masterfrom
lukaszstolarczuk:bring-back-coverage-build
Jun 11, 2021
Merged

Revert "gha: temporarily disable codecov"#1085
igchor merged 1 commit intopmem:masterfrom
lukaszstolarczuk:bring-back-coverage-build

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Jun 10, 2021

This reverts commit 7a41d10.

It should be working now.


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 10, 2021

Codecov Report

Merging #1085 (01a33e6) into master (cfde2f4) will increase coverage by 0.27%.
The diff coverage is 99.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
+ Coverage   93.99%   94.26%   +0.27%     
==========================================
  Files          49       51       +2     
  Lines        4726     4971     +245     
==========================================
+ Hits         4442     4686     +244     
- Misses        284      285       +1     
Flag Coverage Δ
tests_clang_debug_cpp17 93.79% <99.18%> (+0.32%) ⬆️
tests_gcc_debug 91.98% <96.24%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/detail/life.hpp 97.22% <ø> (-0.78%) ⬇️
include/libpmemobj++/detail/ringbuf.hpp 98.38% <98.38%> (ø)
include/libpmemobj++/experimental/mpsc_queue.hpp 100.00% <100.00%> (ø)
include/libpmemobj++/experimental/radix_tree.hpp 99.46% <100.00%> (+0.05%) ⬆️
include/libpmemobj++/utils.hpp 88.88% <0.00%> (-11.12%) ⬇️
include/libpmemobj++/transaction.hpp 79.83% <0.00%> (-0.81%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.35% <0.00%> (-0.16%) ⬇️
include/libpmemobj++/detail/tagged_ptr.hpp 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a0af7...01a33e6. Read the comment docs.

@igchor igchor merged commit 98e0461 into pmem:master Jun 11, 2021
@lukaszstolarczuk lukaszstolarczuk deleted the bring-back-coverage-build branch June 11, 2021 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants