Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Fix windows CI build#1088

Merged
igchor merged 1 commit intopmem:masterfrom
lukaszstolarczuk:fix-windows-CI-build
Jun 21, 2021
Merged

Fix windows CI build#1088
igchor merged 1 commit intopmem:masterfrom
lukaszstolarczuk:fix-windows-CI-build

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Jun 15, 2021


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 15, 2021

Codecov Report

Merging #1088 (5a6ac2b) into master (bb3a4ee) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 5a6ac2b differs from pull request most recent head 4b724a9. Consider uploading reports for the commit 4b724a9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
- Coverage   94.30%   94.22%   -0.09%     
==========================================
  Files          51       51              
  Lines        5061     4971      -90     
==========================================
- Hits         4773     4684      -89     
+ Misses        288      287       -1     
Flag Coverage Δ
tests_clang_debug_cpp17 93.71% <ø> (-0.13%) ⬇️
tests_gcc_debug 91.74% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/detail/ringbuf.hpp 98.38% <ø> (ø)
include/libpmemobj++/detail/atomic_backoff.hpp 38.46% <0.00%> (-3.85%) ⬇️
include/libpmemobj++/transaction.hpp 79.83% <0.00%> (-0.81%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 93.88% <0.00%> (-0.32%) ⬇️
include/libpmemobj++/detail/tagged_ptr.hpp 100.00% <0.00%> (ø)
include/libpmemobj++/experimental/radix_tree.hpp 99.46% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb3a4ee...4b724a9. Read the comment docs.

…UEUE

we want to enable builds, but current queue implementation
is problematic on Windows - it will be fixed along other queue changes.
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review June 18, 2021 14:12
@igchor igchor merged commit 7416299 into pmem:master Jun 21, 2021
@lukaszstolarczuk lukaszstolarczuk deleted the fix-windows-CI-build branch June 21, 2021 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants